Lg 10386 deprecate in person deactivation reason#8971
Merged
Conversation
we no longer pass in_person_verification_pending to the initialize method for profile maker Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
added this method and split from profile#deactivate_for_in_person_verification_and_schedule_enrollment
changelog: Internal, IdV IPP, write to in_person_verification_pending_at
…controller spec and test against timestamp
note: should we stop tracking deactivation_reason altogether? or preserve it for backwards compatibility?
jmhooper
approved these changes
Sep 5, 2023
jmax-gsa
deleted the
LG-10386-Deprecate-in-person-deactivation-reason
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10386 deprecate in person deactivation reason
🛠 Summary of changes
This PR continues the work of replacing the
in_person_proofing_pendingdeactivation reason with thein_person_proofing_pending_attimestamp by removing thein_person_proofing_pendingdeactivation reason.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
controllers
spec/controllers/idv_controller_spec.rbspec/controllers/idv/personal_key_controller_spec.rbspec/controllers/idv/review_controller_spec.rbspec/controllers/openid_connect/authorization_controller_spec.rbspec/controllers/password_capture_controller_spec.rbspec/controllers/users/piv_cac_login_controller_spec.rbfeatures
spec/features/ialmax/saml_sign_in_spec.rbspec/features/idv/analytics_spec.rbspec/features/idv/in_person_spec.rb<- this is the main one to targetspec/features/idv/sp_requested_attributes_spec.rbspec/features/openid_connect/openid_connect_spec.rbspec/features/reports/authorization_count_spec.rbspec/features/reports/sp_active_users_report_spec.rbspec/features/saml/saml_spec.rbspec/features/users/sign_in_spec.rbspec/features/users/user_profile_spec.rbforms
spec/forms/gpo_verify_form_spec.rbspec/forms/reset_password_form_spec.rbmodels
spec/models/profile_spec.rbservices
spec/services/idv/profile_maker_spec.rbspec/services/idv/session_spec.rb