Consolidate / standardize URL handling for after_sign_in_path_for#9159
Merged
Consolidate / standardize URL handling for after_sign_in_path_for#9159
Conversation
changelog: Internal, Code Quality, Consolidate route handling for after-sign-in behavior
Not common logic
aduth
commented
Sep 6, 2023
aduth
commented
Sep 6, 2023
zachmargolis
approved these changes
Sep 7, 2023
aduth
commented
Sep 7, 2023
matthinz
reviewed
Sep 7, 2023
aduth
commented
Sep 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates handling of signed-in URL handling:
accept_rules_of_use_urlreturnsrules_of_use_pathonly if the user must accept rules of user, otherwise returnsnil).user_fully_authenticated?insigned_in_urlIdeally we would be able to eliminate one or the other of
after_sign_in_path_forandsigned_in_url, but we currently rely onsigned_in_urlfor handling various pending profile states. However, this is something which we ought to reevaluate, since it blocks users from managing their account settings in some cases (see LG-10119).📜 Testing Plan
Verify that there are no regressions in the following prompts: