Move user suspended check for sign-in#9147
Merged
zachmargolis merged 5 commits intomainfrom Sep 6, 2023
Merged
Conversation
- This path is more in-line with other post-2fa steps for sign in changelog: Internal, User suspension, Update suspended user check
olatifflexion
approved these changes
Sep 5, 2023
| two_factor_enabled? | ||
| end | ||
|
|
||
| def confirm_user_is_not_suspended |
Contributor
There was a problem hiding this comment.
is this method still used?
Contributor
Author
There was a problem hiding this comment.
oh whoops it still is as a before filter in a few spots 😬
Contributor
Author
Contributor
There was a problem hiding this comment.
It could probably live in AccountsController instead of ApplicationController? Since it's only used once in that controller.
aduth
approved these changes
Sep 6, 2023
This was referenced Sep 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I had a chat with @aduth about the suspension we implemented in #8755, and we think that the code would catch users signing directly in, not through an SP
What's Changed
application_controller.rb, net result should be about the same