Skip to content

LG-10858 Improve tappable area of LDP footer for mobile users #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinsmaster5 merged 7 commits into from
Sep 11, 2023
Merged

LG-10858 Improve tappable area of LDP footer for mobile users #9156

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4f40dd
changelog: Big Fixes, Accessibility, Improve tappable area of footer …
kevinsmaster5 Sep 6, 2023
7677d48
slight adjustment to footer_links styles
kevinsmaster5 Sep 7, 2023
cd8cc69
refigure cascading order to prefer mobile
kevinsmaster5 Sep 7, 2023
a2c26cc
remove vertical padding on tablet
kevinsmaster5 Sep 8, 2023
7107fd3
reset footer font size to original
kevinsmaster5 Sep 8, 2023
cd826ad
reset footer icon size
kevinsmaster5 Sep 8, 2023
28e3374
remove unneeded size override
kevinsmaster5 Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/assets/stylesheets/components/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ body {
}

a {
@include u-padding-y(1);
text-decoration: none;

@include at-media('tablet') {
@include u-padding-y(0);
&,
&:visited {
color: color($theme-link-reverse-color);
Expand Down Expand Up @@ -59,6 +61,12 @@ body {
}

.footer__links {
@include u-padding-y(1);
@include u-padding-x(1);
display: flex;
flex-wrap: wrap;

@include at-media('tablet') {
@include u-padding-y(1);
@include u-padding-x(0);
}
}