LG-10858 Improve tappable area of LDP footer for mobile users#9156
Merged
kevinsmaster5 merged 7 commits intomainfrom Sep 11, 2023
Merged
LG-10858 Improve tappable area of LDP footer for mobile users#9156kevinsmaster5 merged 7 commits intomainfrom
kevinsmaster5 merged 7 commits intomainfrom
Conversation
kevinsmaster5
force-pushed
the
kmas-lg-10858-improve-tappable-footer-link
branch
from
387371b to
c4f40dd
Compare
aduth
reviewed
Sep 7, 2023
aduth
reviewed
Sep 7, 2023
aduth
reviewed
Sep 8, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM aside from the one comment.
Can you make sure someone from the UX crew signs off on the increased font size? That's the only visual impact I see here. Alternatively, if we could avoid the font size increase while still making the tappable area large enough, there'd not be any visual difference to weigh in on 🤷 No preference from me.
aduth
reviewed
Sep 8, 2023
| @include at-media('tablet') { | ||
| @include u-bg('primary-darker'); | ||
| flex-direction: row; | ||
| font-size: 0.75rem; |
Contributor
There was a problem hiding this comment.
We shouldn't need the override anymore.
Suggested change
| font-size: 0.75rem; |
aduth
approved these changes
Sep 8, 2023
kevinsmaster5
deleted the
kmas-lg-10858-improve-tappable-footer-link
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
LG-10858
🛠 Summary of changes
For mobile users the footer text is now upsized and has added padding to increase target area.