Skip to content

Refactor the InPersonEnrollment model and its tests #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomas-nava merged 6 commits into from
Aug 23, 2023
Merged

Refactor the InPersonEnrollment model and its tests #9062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e4b396
add missing tests, refactor
Aug 22, 2023
0f9a653
refactor
Aug 22, 2023
8f6df10
use change to be saved helper methods
Aug 22, 2023
e431c14
fix test description
Aug 23, 2023
9355b05
Merge remote-tracking branch 'origin/main' into tomas/refactor-in-per…
Aug 23, 2023
b80dd0a
Merge remote-tracking branch 'origin/main' into tomas/refactor-in-per…
Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 66 additions & 60 deletions app/models/in_person_enrollment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,44 +34,64 @@ class InPersonEnrollment < ApplicationRecord
before_create(:set_unique_id, unless: :unique_id)
before_create(:set_capture_secondary_id)

def self.is_pending_and_established_between(early_benchmark, late_benchmark)
where(status: :pending).
and(
where(enrollment_established_at: late_benchmark...(early_benchmark.end_of_day)),
).
order(enrollment_established_at: :asc)
end
class << self
def needs_early_email_reminder(early_benchmark, late_benchmark)
is_pending_and_established_between(
early_benchmark,
late_benchmark,
).where(early_reminder_sent: false)
end

def self.needs_early_email_reminder(early_benchmark, late_benchmark)
self.is_pending_and_established_between(
early_benchmark,
late_benchmark,
).where(early_reminder_sent: false)
end
def needs_late_email_reminder(early_benchmark, late_benchmark)
is_pending_and_established_between(
early_benchmark,
late_benchmark,
).where(late_reminder_sent: false)
end

def self.needs_late_email_reminder(early_benchmark, late_benchmark)
self.is_pending_and_established_between(
early_benchmark,
late_benchmark,
).where(late_reminder_sent: false)
end
# Find enrollments that need a status check via the USPS API
def needs_usps_status_check(check_interval)
where(status: :pending).
and(
where(last_batch_claimed_at: check_interval).
or(where(last_batch_claimed_at: nil)),
)
end

# Find enrollments that need a status check via the USPS API
def self.needs_usps_status_check(check_interval)
where(status: :pending).
and(
where(last_batch_claimed_at: check_interval).
or(where(last_batch_claimed_at: nil)),
)
end
def needs_usps_status_check_batch(batch_at)
where(status: :pending).
and(
where(last_batch_claimed_at: batch_at),
).
order(status_check_attempted_at: :asc)
end

# Find enrollments that are ready for a status check via the USPS API
def needs_status_check_on_ready_enrollments(check_interval)
needs_usps_status_check(check_interval).where(ready_for_status_check: true)
end

def self.needs_usps_status_check_batch(batch_at)
where(status: :pending).
and(
where(last_batch_claimed_at: batch_at),
).
order(status_check_attempted_at: :asc)
# Find waiting enrollments that need a status check via the USPS API
def needs_status_check_on_waiting_enrollments(check_interval)
needs_usps_status_check(check_interval).where(ready_for_status_check: false)
end

# Generates a random 18-digit string, the hex returns a string of length n*2
def generate_unique_id
SecureRandom.hex(9)
end

private

def is_pending_and_established_between(early_benchmark, late_benchmark)
where(status: :pending).
and(
where(enrollment_established_at: late_benchmark...(early_benchmark.end_of_day)),
).
order(enrollment_established_at: :asc)
end
end
# end class methods

# Does this enrollment need a status check via the USPS API?
def needs_usps_status_check?(check_interval)
Expand All @@ -81,21 +101,11 @@ def needs_usps_status_check?(check_interval)
)
end

# Find enrollments that are ready for a status check via the USPS API
def self.needs_status_check_on_ready_enrollments(check_interval)
needs_usps_status_check(check_interval).where(ready_for_status_check: true)
end

# Does this ready enrollment need a status check via the USPS API?
def needs_status_check_on_ready_enrollment?(check_interval)
needs_usps_status_check?(check_interval) && ready_for_status_check?
end

# Find waiting enrollments that need a status check via the USPS API
def self.needs_status_check_on_waiting_enrollments(check_interval)
needs_usps_status_check(check_interval).where(ready_for_status_check: false)
end

# Does this waiting enrollment need a status check via the USPS API?
def needs_status_check_on_waiting_enrollment?(check_interval)
needs_usps_status_check?(check_interval) && !ready_for_status_check?
Expand All @@ -121,16 +131,6 @@ def minutes_since_last_status_update
(Time.zone.now - status_updated_at).seconds.in_minutes.round(2)
end

# (deprecated) Returns the value to use for the USPS enrollment ID
def usps_unique_id
user.uuid.delete('-').slice(0, 18)
end

# Generates a random 18-digit string, the hex returns a string of length n*2
def self.generate_unique_id
SecureRandom.hex(9)
end

def due_date
start_date = enrollment_established_at.presence || created_at
start_date + IdentityConfig.store.in_person_enrollment_validity_in_days.days
Expand All @@ -141,18 +141,24 @@ def days_to_due_date
(today...due_date).count
end

def on_notification_sent_at_updated
if self.notification_sent_at && self.notification_phone_configuration
self.notification_phone_configuration.destroy
end
def eligible_for_notification?
notification_phone_configuration.present? && (passed? || failed?)
end

def eligible_for_notification?
self.notification_phone_configuration.present? && (self.passed? || self.failed?)
# (deprecated) Returns the value to use for the USPS enrollment ID
def usps_unique_id
user.uuid.delete('-').slice(0, 18)
end

private

def on_notification_sent_at_updated
change_will_be_saved = notification_sent_at_change_to_be_saved&.last.present?
if change_will_be_saved && notification_phone_configuration.present?
notification_phone_configuration.destroy
end
end

def on_status_updated
if enrollment_will_be_cancelled_or_expired? && notification_phone_configuration.present?
notification_phone_configuration.destroy!
Expand All @@ -165,7 +171,7 @@ def enrollment_will_be_cancelled_or_expired?
end

def set_unique_id
self.unique_id = self.class.generate_unique_id
self.unique_id = InPersonEnrollment.generate_unique_id
end

def profile_belongs_to_user
Expand Down
Loading