Skip to content

Refactor the InPersonEnrollment model and its tests#9062

Merged
tomas-nava merged 6 commits intomainfrom
tomas/refactor-in-person-enrollment-model
Aug 23, 2023
Merged

Refactor the InPersonEnrollment model and its tests#9062
tomas-nava merged 6 commits intomainfrom
tomas/refactor-in-person-enrollment-model

Conversation

@tomas-nava
Copy link
Contributor

🛠 Summary of changes

Refactors the InPersonEnrollment model and its tests; adds some new tests to complete coverage.

Tomas Apodaca added 3 commits August 22, 2023 14:47
changelog: Internal, In-person proofing, Refactor InPersonEnrollment model and tests
- move class methods into a class << self block
- make private methods private
- only use "self" when necessary
to make it clearer what we're checking for
@tomas-nava tomas-nava requested review from a team and gina-yamada August 22, 2023 22:02
@tomas-nava tomas-nava merged commit 7fea89d into main Aug 23, 2023
@tomas-nava tomas-nava deleted the tomas/refactor-in-person-enrollment-model branch August 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants