Skip to content

LG-10594: remove no longer needed extend timeout from link sent #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 6 commits into from
Aug 22, 2023
Merged

LG-10594: remove no longer needed extend timeout from link sent #9037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfcd000
remove extend_timeout_using_meta_refresh before action
amirbey Aug 17, 2023
1d631f8
remove extend_timeout_using_meta_refresh before action from link sent…
amirbey Aug 18, 2023
93dcc7f
remove meta refresh from link_sent show template
amirbey Aug 18, 2023
51be829
Co-authored-by: Sonia Connolly<sonia.connolly@gsa.gov>
amirbey Aug 18, 2023
1351b75
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
amirbey Aug 18, 2023
5e3e07a
Remove doc_auth_extend_timeout_by_minutes config -- no longer used
amirbey Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions app/controllers/idv/link_sent_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ class LinkSentController < ApplicationController

before_action :confirm_hybrid_handoff_complete
before_action :confirm_document_capture_needed
before_action :extend_timeout_using_meta_refresh

def show
analytics.idv_doc_auth_link_sent_visited(**analytics_arguments)
Expand Down Expand Up @@ -91,18 +90,5 @@ def document_capture_session_result
document_capture_session&.load_doc_auth_async_result
end
end

def extend_timeout_using_meta_refresh
max_10min_refreshes = IdentityConfig.store.doc_auth_extend_timeout_by_minutes / 10
Comment thread
aduth marked this conversation as resolved.
return if max_10min_refreshes <= 0
meta_refresh_count = flow_session[:meta_refresh_count].to_i
return if meta_refresh_count >= max_10min_refreshes
do_meta_refresh(meta_refresh_count)
end

def do_meta_refresh(meta_refresh_count)
@meta_refresh = 10 * 60
flow_session[:meta_refresh_count] = meta_refresh_count + 1
end
end
end
4 changes: 0 additions & 4 deletions app/views/idv/link_sent/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@

<% title t('titles.doc_auth.link_sent') %>

<!-- Hide meta refresh if we are polling -->
<% if @meta_refresh && !FeatureManagement.doc_capture_polling_enabled? %>
<%= content_for(:meta_refresh) { @meta_refresh.to_s } %>
<% end %>
<% if flow_session[:error_message] %>
<%= render AlertComponent.new(
type: :error,
Expand Down
1 change: 0 additions & 1 deletion config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ disable_logout_get_request: true
disallow_all_web_crawlers: true
disposable_email_services: '[]'
doc_auth_attempt_window_in_minutes: 360
doc_auth_extend_timeout_by_minutes: 40
doc_capture_polling_enabled: true
doc_auth_client_glare_threshold: 50
doc_auth_client_sharpness_threshold: 50
Expand Down
1 change: 0 additions & 1 deletion lib/identity_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ def self.build_store(config_map)
config.add(:doc_auth_error_dpi_threshold, type: :integer)
config.add(:doc_auth_error_glare_threshold, type: :integer)
config.add(:doc_auth_error_sharpness_threshold, type: :integer)
config.add(:doc_auth_extend_timeout_by_minutes, type: :integer)
config.add(:doc_auth_max_attempts, type: :integer)
config.add(:doc_auth_max_capture_attempts_before_native_camera, type: :integer)
config.add(:doc_auth_max_capture_attempts_before_tips, type: :integer)
Expand Down