Conversation
… controller changelog: Internal, Identity Verification, Remove no longer needed timeout extension for link sent
amirbey
force-pushed
the
amirbey/LG-10594-remove-extend_timeout_using_meta_refresh
branch
from
3de00ae to
1351b75
Compare
aduth
reviewed
Aug 18, 2023
soniaconnolly
approved these changes
Aug 18, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. Didn't find any other references to flow_session[:meta_refresh_count], and LinkSent polling worked fine and progressed to SsnStep when I tried it locally on this branch.
amirbey
deleted the
amirbey/LG-10594-remove-extend_timeout_using_meta_refresh
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10594
🛠 Summary of changes
Remove extend_timeout_using_meta_refresh before_action form link sent controller which is no longer needed for current polling method.