Skip to content

LG-10543 Delete flow_session[:redo_document_capture] and flow_session['redo_document_capture']#8992

Merged
soniaconnolly merged 8 commits intomainfrom
sonia-lg-10593-delete-flow-session-redo-document-capture
Aug 15, 2023
Merged

LG-10543 Delete flow_session[:redo_document_capture] and flow_session['redo_document_capture']#8992
soniaconnolly merged 8 commits intomainfrom
sonia-lg-10593-delete-flow-session-redo-document-capture

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Aug 11, 2023

🎫 Ticket

LG-10593

🛠 Summary of changes

We are removing attributes from flow_session now that we are not using the Flow State Machine. The redo_document_capture attribute is used to track when someone clicks to redo document capture in VerifyInfo after a barcode read error.

Followup to #8991. After it is deployed, remove all references to flow_session[:redo_document_capture] and flow_session['redo_document_capture']. (flow_session is a hash with indifferent access)

Also clean up a couple of leftover flow_session attributes that are no longer in use.

📜 Testing Plan

  • Create account
  • Start IdV
  • Choose Upload Documents, and upload a yml file with a barcode read error
  • Choose to Continue
  • On the VerifyInfo page, click on the link to redo document capture.
  • Check events.log: Expect the 'IdV: doc auth document_capture visited' analytics event to have attribute redo_document_capture: true
  • Continue IdV and expect to get past VerifyInfo successfully

We are removing attributes from flow_session now that we are not using the Flow State Machine. The redo_document_capture
attribute is used to track when someone clicks to redo document capture in VerifyInfo after a barcode read error.

[skip changelog]
…cument_capture']

A previous commit replaced them with idv_session.redo_document_capture

[skip changelog]
@soniaconnolly soniaconnolly requested a review from a team August 14, 2023 23:06
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soniaconnolly soniaconnolly merged commit 672aa19 into main Aug 15, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-10593-delete-flow-session-redo-document-capture branch August 15, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants