Skip to content

Jmax/lg 10419 update phone and verify info attempts screen to use less bolding#8870

Merged
jmax-gsa merged 11 commits intomainfrom
jmax/LG-10419-update-phone-and-verify-info-attempts-screen-to-use-less-bolding
Jul 31, 2023
Merged

Jmax/lg 10419 update phone and verify info attempts screen to use less bolding#8870
jmax-gsa merged 11 commits intomainfrom
jmax/LG-10419-update-phone-and-verify-info-attempts-screen-to-use-less-bolding

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Jul 26, 2023

🎫 Ticket

LG-10419

🛠 Summary of changes

Changed the bolding of text on three of the error screens (see ticket) for increased clarity.
Note that one of the screens (the image upload screen) had been caught by a previous ticket, so this PR contains changes for only two of the screens. The test plan verifies that all three are correct.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Apply this modified presenter to force an error after image upload. Verify that the 'remaining attempts' text on the error screen is bolded correctly.
  • Apply this modified phone controller to force an error after phone number verification. Verify that the 'remaining attempts' text on the error screen is bolded correctly.
  • Apply this modified verify info concern to force an error after the info verify screen. Verify that the error screen is bolded correctly.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

Image Upload Failure

Information Verify Failure

Phone Verification Failure

After:

Image Upload Failure

Information Verify Failure

Phone Verification Failure

@jmax-gsa jmax-gsa force-pushed the jmax/LG-10419-update-phone-and-verify-info-attempts-screen-to-use-less-bolding branch from 04d3802 to d7a4395 Compare July 27, 2023 16:20
Changelog: User Facing Improvement, Remote Proofing, Improved display of remaining number of attempts
@jmax-gsa jmax-gsa force-pushed the jmax/LG-10419-update-phone-and-verify-info-attempts-screen-to-use-less-bolding branch from d7a4395 to 56d53cc Compare July 27, 2023 16:28
@jmax-gsa jmax-gsa requested review from a team and soniaconnolly July 27, 2023 17:05
@jmax-gsa jmax-gsa marked this pull request as ready for review July 27, 2023 17:05
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending moving a couple of periods outside tags, and possibly making Spanish translations consistent between statements.

jmax-gsa and others added 3 commits July 31, 2023 11:02
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
@jmax-gsa jmax-gsa merged commit 5160de1 into main Jul 31, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-10419-update-phone-and-verify-info-attempts-screen-to-use-less-bolding branch July 31, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants