LG-10248: Send in-person proofing notifications based on the status update time#8848
Merged
LG-10248: Send in-person proofing notifications based on the status update time#8848
Conversation
…pdate time changelog: Bug Fixes, In-Person Proofing, Send in-person proofing notifications based on the status update time instead of the proofing time
Contributor
|
@NavaTim in order to verify this step: |
tomas-nava
approved these changes
Jul 25, 2023
Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
Contributor
Author
@svalexander You can expand the jobs in the web interface, which shows the time when each job is scheduled to run. The timing is the relevant part of the test here (and params somewhat), not so much the SMS/email itself. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10248
🛠 Summary of changes
📜 Testing Plan
Note that this may be more easily simulated for a local dev stack by using a command like the following:
The details of the associated jobs can be observed by enabling the GoodJob dashboard and preserving job records.
This was tested locally by stubbing the proofer's API response using the
request_passed_proofing_results_responsefixture.