Skip to content

LG-10248: Send in-person proofing notifications based on the status update time#8848

Merged
NavaTim merged 2 commits intomainfrom
tbradley/lg-10248-notification-timing
Jul 25, 2023
Merged

LG-10248: Send in-person proofing notifications based on the status update time#8848
NavaTim merged 2 commits intomainfrom
tbradley/lg-10248-notification-timing

Conversation

@NavaTim
Copy link
Contributor

@NavaTim NavaTim commented Jul 24, 2023

🎫 Ticket

LG-10248

🛠 Summary of changes

  • Send in-person proofing email and SMS based on the time we received a status update from USPS
  • Minor nonfunctional refactoring of the job
  • Minor test updates

📜 Testing Plan

  • Enroll for in-person proofing
  • Complete in-person step (at post office or simulated)
  • Run proofing results job
  • Verify that notifications are received one hour after results are received from USPS

Note that this may be more easily simulated for a local dev stack by using a command like the following:

bundle exec rails dev:random_in_person_users NUM_USERS='1' SCRYPT_COST='800$8$1$' ENROLLMENT_STATUS='pending'

The details of the associated jobs can be observed by enabling the GoodJob dashboard and preserving job records.

This was tested locally by stubbing the proofer's API response using the request_passed_proofing_results_response fixture.

…pdate time

changelog: Bug Fixes, In-Person Proofing, Send in-person proofing notifications based on the status update time instead of the proofing time
@svalexander
Copy link
Contributor

@NavaTim in order to verify this step: Verify that notifications are received one hour after results are received from USPS should we proof using our actual phone number (to receive sms)?

Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
@NavaTim
Copy link
Contributor Author

NavaTim commented Jul 25, 2023

@NavaTim in order to verify this step: Verify that notifications are received one hour after results are received from USPS should we proof using our actual phone number (to receive sms)?

@svalexander You can expand the jobs in the web interface, which shows the time when each job is scheduled to run. The timing is the relevant part of the test here (and params somewhat), not so much the SMS/email itself.

@NavaTim NavaTim merged commit 938e5c0 into main Jul 25, 2023
@NavaTim NavaTim deleted the tbradley/lg-10248-notification-timing branch July 25, 2023 17:35
@amirbey amirbey mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants