LG-10126: SendProofingNotificationJob refactor#8843
Merged
tomas-nava merged 16 commits intomainfrom Jul 26, 2023
Merged
Conversation
added 8 commits
July 24, 2023 12:06
changelog: Internal, In-person proofing, refactor SendProofingNotificationJob
move 'completed' log to a private method
- log completed separately for expired - fix test - add test for enrollment that doesn't exist
- rename telephony_result -> telephony_response for consistency - convert response to hash before sending to analytics - generalize analytics call
NavaTim
reviewed
Jul 24, 2023
NavaTim
approved these changes
Jul 25, 2023
Contributor
NavaTim
left a comment
NavaTim
left a comment
There was a problem hiding this comment.
Approved since the user-facing changes (not notifying for unsupported status) are an improvement on the status quo. I highly recommend that the ensure block change is addressed before merging. The other issues are important but low-priority enough that they could be addressed in another PR.
Note that #8848 touches some of the same code and tests; when one of these is merged then it is likely the other will need adjustments.
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 26, 2023
* Only invoke the job when we get a pass/fail from the USPS API * Log notification job 'skipped' when the enrollment can't be found (instead of 'completed') * Capture exceptions and log them with a new analytics event * Convert telephony response to a hash before logging it changelog: Internal, In-person proofing, refactor SendProofingNotificationJob
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to LG-10126
🛠 Summary of changes
Follow-up to #8772, refactors related to the implementation of
SendProofingNotificationJob.The only functional changes: