Skip to content

fix _html on keys #8708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdembe merged 5 commits into from
Jul 3, 2023
Merged

fix _html on keys #8708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46c7fd1
fix `_html` on keys
jmdembe Jul 3, 2023
ef62aa7
fix spec
jmdembe Jul 3, 2023
a31dfed
[skip changelog]
jmdembe Jul 3, 2023
d5d326b
modify I need new backup codes test
jmdembe Jul 3, 2023
94c4662
Update spec/features/two_factor_authentication/multiple_mfa_sign_up_s…
jmdembe Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/users/backup_code_setup/confirm_backup_codes.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
big: true,
full_width: true,
outline: true,
).with_content(t('two_factor_authentication.backup_codes.new_backup_codes')) %>
).with_content(t('two_factor_authentication.backup_codes.new_backup_codes_html')) %>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ en:
instructions: If you don’t have access to another device, keep your backup codes
safe. If you lose your backup codes, you won’t be able to sign into
%{app_name}.
new_backup_codes: I need new backup&nbsp;codes
new_backup_codes_html: I need new backup&nbsp;codes
Copy link
Contributor

@zachmargolis zachmargolis Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like something we can lint on to detect! I will noodle on some ideas

saved_backup_codes: I’ve saved my backup codes
warning_html: <strong>You’ve only set up backup codes on your account.
</strong>If you have access to another device, such as a phone, protect
Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ es:
instructions: Si no tiene acceso a otro dispositivo, guarde bien sus códigos de
respaldo. No podrá iniciar sesión en %{app_name} si pierde sus códigos
de respaldo.
new_backup_codes: Necesito nuevos códigos de respaldo
new_backup_codes_html: Necesito nuevos códigos de respaldo
saved_backup_codes: Ya guardé mis códigos de respaldo
warning_html: <strong>Solo ha configurado códigos de respaldo en su cuenta.
</strong>Si tiene acceso a otro dispositivo, como un celular, proteja su
Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ fr:
instructions: Si vous n’avez pas accès à un autre appareil, conservez vos codes
de sauvegarde en lieu sûr. Si vous perdez vos codes de sauvegarde, vous
ne pourrez plus vous connecter à %{app_name}.
new_backup_codes: J’ai besoin de nouveaux codes de sauvegarde
new_backup_codes_html: J’ai besoin de nouveaux codes de sauvegarde
saved_backup_codes: J’ai sauvegardé mes codes de sauvegarde
warning_html: <strong>Vous n’avez configuré que des codes de sauvegarde sur
votre compte. </strong>Si vous avez accès à un autre appareil, tel qu’un
Expand Down
2 changes: 1 addition & 1 deletion spec/features/two_factor_authentication/multiple_mfa_sign_up_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
end

it 'regenerates backup codes path if a user clicks that they need new backup codes' do
click_link t('two_factor_authentication.backup_codes.new_backup_codes')
click_link strip_tags(t('two_factor_authentication.backup_codes.new_backup_codes_html'))
expect(page).to have_current_path backup_code_regenerate_path
end
end
Expand Down