Skip to content

Refactor verify info update #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 5 commits into from
Jun 14, 2023
Merged

Refactor verify info update #8595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9924526
Give each verify_info_controller its own update method
soniaconnolly Jun 13, 2023
58644b1
Move final redirects into individual update methods
soniaconnolly Jun 13, 2023
39d8e32
Only mark InPerson::VerifyStep complete in InPerson::VerifyInfoContro…
soniaconnolly Jun 13, 2023
b21c1ca
Move redo_document_capture check to doc_auth VerifyInfoController
soniaconnolly Jun 13, 2023
31f674e
Remove empty verify_info/new template accidentally added back in Jan.
soniaconnolly Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions app/controllers/concerns/idv/verify_info_concern.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Idv
module VerifyInfoConcern
extend ActiveSupport::Concern

def update
def shared_update
return if idv_session.verify_info_step_document_capture_session_uuid
analytics.idv_doc_auth_verify_submitted(**analytics_arguments)
Funnel::DocAuth::RegisterStep.new(current_user.id, sp_session[:issuer]).
Expand Down Expand Up @@ -48,15 +48,7 @@ def update
double_address_verification: capture_secondary_id_enabled,
)

# Don't allow the user to go back to document capture after verifying
if flow_session['redo_document_capture']
flow_session.delete('redo_document_capture')
flow_session[:flow_path] ||= 'standard'
end

# Mark the FSM verify step completed. This is for the 50/50 state
flow_session['Idv::Steps::InPerson::VerifyStep'] = true
redirect_to after_update_url
return true
end

private
Expand Down
15 changes: 11 additions & 4 deletions app/controllers/idv/in_person/verify_info_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ def show
process_async_state(load_async_state)
end

def update
success = shared_update

if success
# Mark the FSM verify step completed. This is for the 50/50 state
flow_session['Idv::Steps::InPerson::VerifyStep'] = true

redirect_to idv_in_person_verify_info_url
end
end

private

# state_id_type is hard-coded here because it's required for proofing against
Expand All @@ -50,10 +61,6 @@ def invalid_state?
pii.blank?
end

def after_update_url
idv_in_person_verify_info_url
end

def prev_url
idv_in_person_step_url(step: :ssn)
end
Expand Down
18 changes: 14 additions & 4 deletions app/controllers/idv/verify_info_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,25 @@ def show
process_async_state(load_async_state)
end

def update
success = shared_update

if success
# Don't allow the user to go back to document capture after verifying
if flow_session['redo_document_capture']
Copy link
Copy Markdown
Contributor

@JackRyan1989 JackRyan1989 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soniaconnolly I'm pretty sure this isn't an issue for IPP, but how did your team encounter this behavior? I just want to make sure we don't also need this code.

Copy link
Copy Markdown
Contributor Author

@soniaconnolly soniaconnolly Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See LG-9996 and slack thread. VerifyInfo shows the user the option to redo document capture if they had a barcode read error. The code that lets the user redo is in the in_person verify_info show template, but I think it can be removed, since people can't get to the in person flow unless their ID couldn't be scanned.

Copy link
Copy Markdown
Contributor

@JackRyan1989 JackRyan1989 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that that code can be deleted from the in_person verify_info show template. The @had_barcode_read_failure is not set in our controller. I can open a separate ticket for that work.

Thanks for flagging this!

flow_session.delete('redo_document_capture')
flow_session[:flow_path] ||= 'standard'
end

redirect_to idv_verify_info_url
end
end

private

# state ID type isn't manually set for Idv::VerifyInfoController
def set_state_id_type; end

def after_update_url
idv_verify_info_url
end

def prev_url
idv_ssn_url
end
Expand Down
Empty file removed app/views/idv/verify_info/new.html.erb
View file
Open in desktop
Empty file.