-
Notifications
You must be signed in to change notification settings - Fork 166
LG-10029: verified_at not updated during password reset #8546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c0c254f
do not update verified_at when activating a profile due to a password…
amirbey 04e4e0d
happy linting
amirbey 1565b95
keep test checks from password_reset of unverified profile in test fo…
amirbey 7779945
udpate activate signature style to symbol
amirbey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,18 +46,22 @@ def pending_reasons | |
| end | ||
|
|
||
| # rubocop:disable Rails/SkipsModelValidations | ||
| def activate | ||
| def activate(reason_deactivated: nil) | ||
| confirm_that_profile_can_be_activated! | ||
|
|
||
| now = Time.zone.now | ||
| is_reproof = Profile.find_by(user_id: user_id, active: true) | ||
|
|
||
| attrs = { | ||
| active: true, | ||
| activated_at: now, | ||
| } | ||
|
|
||
| attrs[:verified_at] = now unless reason_deactivated == :password_reset | ||
|
|
||
| transaction do | ||
| Profile.where(user_id: user_id).update_all(active: false) | ||
| update!( | ||
| active: true, | ||
| activated_at: now, | ||
| verified_at: now, | ||
| ) | ||
| update!(attrs) | ||
| end | ||
| send_push_notifications if is_reproof | ||
| end | ||
|
|
@@ -97,7 +101,7 @@ def activate_after_password_reset | |
| update!( | ||
| deactivation_reason: nil, | ||
| ) | ||
| activate | ||
| activate(reason_deactivated: :password_reset) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this pattern! Then we can coalesce the behavior for different reasons inside activate. |
||
| end | ||
| end | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangential to this PR since it was here already. Does this mean validations are enabled or disabled, and is that the way we want it?