Skip to content

Sort analytics events #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 6 commits into from
Jun 1, 2023
Merged

Sort analytics events #8519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7549baa
Remove a couple of stray extra lines in analytics_events.rb
matthinz May 31, 2023
32356e3
Sort analytics_events.rb
matthinz May 31, 2023
7690a1f
Check analytics events are sorted during lint
matthinz May 31, 2023
52e2966
Add important notice to the top of the file
matthinz May 31, 2023
c29940c
Purposefully sort analytics events incorrectly to test CI
matthinz Jun 1, 2023
3f51c1a
Revert "Purposefully sort analytics events incorrectly to test CI"
matthinz Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ARTIFACT_DESTINATION_FILE ?= ./tmp/idp.tar.gz
help \
lint \
lint_analytics_events \
lint_analytics_events_sorted \
lint_tracker_events \
lint_country_dialing_codes \
lint_erb \
Expand Down Expand Up @@ -75,6 +76,7 @@ endif
@echo "--- analytics_events ---"
make lint_analytics_events
make lint_tracker_events
make lint_analytics_events_sorted
@echo "--- brakeman ---"
bundle exec brakeman
@echo "--- bundler-audit ---"
Expand Down Expand Up @@ -102,6 +104,7 @@ endif
@echo "--- lint migrations ---"
make lint_migrations


lint_erb: ## Lints ERB files
bundle exec erblint app/views app/components

Expand Down Expand Up @@ -247,6 +250,10 @@ analytics_events: public/api/_analytics-events.json ## Generates a JSON file tha
lint_analytics_events: .yardoc ## Checks that all methods on AnalyticsEvents are documented
bundle exec ruby lib/analytics_events_documenter.rb --class-name="AnalyticsEvents" --check $<

lint_analytics_events_sorted:
@test "$(shell grep '^ def ' app/services/analytics_events.rb)" = "$(shell grep '^ def ' app/services/analytics_events.rb | sort)" \
|| (echo 'Error: methods in analytics_events.rb are not sorted alphabetically' && exit 1)

lint_tracker_events: .yardoc ## Checks that all methods on AnalyticsEvents are documented
bundle exec ruby lib/analytics_events_documenter.rb --class-name="IrsAttemptsApi::TrackerEvents" --check --skip-extra-params $<

Expand Down
Loading