Conversation
changelog: Internal, analytics, Sort analytics_events.rb and enforce sorting in CI
zachmargolis
reviewed
Jun 1, 2023
| @@ -1,6 +1,33 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # ______________________________________ | |||
| # / Adding something new in here? Please \ | |||
Contributor
There was a problem hiding this comment.
Reminds me of the time we added an ASCII dragon on an old project to highlight a load-bearing legacy file
Contributor
Author
There was a problem hiding this comment.
I figured that cowsay would increase the likelihood of people reading the message
it occurs to me that i should ensure the combo of make / sh / grep on the ci runner delivers the same behavior as it does locally
This reverts commit c29940c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analytics_events.rbis almost 4000 lines long, and the methods in it are not sorted alphabetically. This bugs me, so I sorted them and added a step tomake lintthat will error out if they're not kept sorted.Does it make sense that I want to be able to scroll through this 4000 line file rather than just use the search function of my text editor? No, it does not. Is this a transparent attempt to juice my commit stats? Possibly. Is there a better way to do this, like with rubocop or something? Probably!
Testing
analytics_events.rb, but purposefully DO NOT put it in the correct alphabetical positionmake lint_analytics_events_sortedand get yelled atmake lint_analytics_events_sortedagain and don't get yelled atThis is a noisy PR and likely to cause problems for people who have outstanding changes to
analytics_events.rb. For this I apologize.