LG-9371 delete upload step

app/controllers/concerns/idv_step_concern.rb

@@ -48,8 +48,8 @@ def confirm_document_capture_complete
       redirect_to idv_document_capture_url
     elsif flow_path == 'hybrid'
       redirect_to idv_link_sent_url
-    else # no flow_path, go to UploadStep via FSM
-      redirect_to idv_doc_auth_url
+    else # no flow_path
+      redirect_to idv_hybrid_handoff_path
     end
   end
 

app/controllers/idv/doc_auth_controller.rb

@@ -21,7 +21,7 @@ class DocAuthController < ApplicationController
 
     FLOW_STATE_MACHINE_SETTINGS = {
       step_url: :idv_doc_auth_step_url,
-      final_url: :idv_link_sent_url,
+      final_url: :idv_hybrid_handoff_url,
       flow: Idv::Flows::DocAuthFlow,
       analytics_id: 'Doc Auth',
     }.freeze

app/controllers/idv/document_capture_controller.rb

@@ -56,11 +56,7 @@ def extra_view_variables
     def confirm_upload_step_complete
       return if flow_session[:flow_path].present?
 
-      if IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
-        redirect_to idv_hybrid_handoff_url
-      else
-        redirect_to idv_doc_auth_url
-      end
+      redirect_to idv_hybrid_handoff_url
     end
 
     def confirm_document_capture_needed

app/controllers/idv/hybrid_handoff_controller.rb

@@ -45,7 +45,6 @@ def handle_phone_submission
       throttle.increment!
       return throttled_failure if throttle.throttled?
       idv_session.phone_for_mobile_flow = params[:doc_auth][:phone]
-      flow_session[:phone_for_mobile_flow] = idv_session.phone_for_mobile_flow
       flow_session[:flow_path] = 'hybrid'
       telephony_result = send_link
       telephony_form_response = build_telephony_form_response(telephony_result)
@@ -63,9 +62,6 @@ def handle_phone_submission
 
       if !failure_reason
         redirect_to idv_link_sent_url
-
-        # for the 50/50 state
-        flow_session['Idv::Steps::UploadStep'] = true
       else
         redirect_to idv_hybrid_handoff_url
         flow_session[:flow_path] = nil
@@ -124,9 +120,6 @@ def bypass_send_link_steps
       flow_session[:flow_path] = 'standard'
       redirect_to idv_document_capture_url
 
-      # for the 50/50 state
-      flow_session['Idv::Steps::UploadStep'] = true
-
       analytics.idv_doc_auth_upload_submitted(
         **analytics_arguments.merge(
           form_response(destination: :document_capture).to_h,

app/controllers/idv/link_sent_controller.rb

@@ -36,7 +36,7 @@ def update
     end
 
     def extra_view_variables
-      { phone: flow_session[:phone_for_mobile_flow],
+      { phone: idv_session.phone_for_mobile_flow,
         flow_session: flow_session }
     end
 
@@ -47,10 +47,8 @@ def confirm_upload_step_complete
 
       if flow_session[:flow_path] == 'standard'
         redirect_to idv_document_capture_url
-      elsif IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
-        redirect_to idv_hybrid_handoff_url
       else
-        redirect_to idv_doc_auth_url
+        redirect_to idv_hybrid_handoff_url
       end
     end
 
@@ -75,18 +73,12 @@ def analytics_arguments
     def handle_document_verification_success(get_results_response)
       save_proofing_components(current_user)
       extract_pii_from_doc(current_user, get_results_response, store_in_session: true)
-      mark_upload_step_complete
       flow_session[:flow_path] = 'hybrid'
     end
 
     def render_document_capture_cancelled
-      if IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
-        redirect_to idv_hybrid_handoff_url
-        flow_session[:flow_path] = nil
-      else
-        mark_upload_step_incomplete
-        redirect_to idv_doc_auth_url # was idv_url, why?
-      end
+      redirect_to idv_hybrid_handoff_url
+      flow_session[:flow_path] = nil
       failure(I18n.t('errors.doc_auth.document_capture_cancelled'))
     end
 
@@ -105,14 +97,6 @@ def document_capture_session_result
       end
     end
 
-    def mark_upload_step_complete
-      flow_session['Idv::Steps::UploadStep'] = true
-    end
-
-    def mark_upload_step_incomplete
-      flow_session['Idv::Steps::UploadStep'] = nil
-    end
-
     def extend_timeout_using_meta_refresh
       max_10min_refreshes = IdentityConfig.store.doc_auth_extend_timeout_by_minutes / 10
       return if max_10min_refreshes <= 0

app/services/idv/actions/cancel_link_sent_action.rb

@@ -6,12 +6,8 @@ def self.analytics_submitted_event
       end
 
       def call
-        if IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
-          redirect_to idv_hybrid_handoff_url
-          flow_session[:flow_path] = nil
-        else
-          mark_step_incomplete(:upload)
-        end
+        redirect_to idv_hybrid_handoff_url
+        flow_session[:flow_path] = nil
       end
     end
   end

app/services/idv/actions/redo_document_capture_action.rb

@@ -9,11 +9,9 @@ def call
         flow_session['redo_document_capture'] = true
         if flow_session[:skip_upload_step]
           redirect_to idv_document_capture_url
-        elsif IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
+        else
           redirect_to idv_hybrid_handoff_url
           flow_session[:flow_path] = nil
-        else
-          mark_step_incomplete(:upload)
         end
       end
     end

app/services/idv/flows/doc_auth_flow.rb

@@ -4,7 +4,6 @@ class DocAuthFlow < Flow::BaseFlow
       STEPS = {
         welcome: Idv::Steps::WelcomeStep,
         agreement: Idv::Steps::AgreementStep,
-        upload: Idv::Steps::UploadStep,
       }.freeze
 
       STEP_INDICATOR_STEPS = [

app/services/idv/steps/agreement_step.rb

@@ -12,8 +12,6 @@ def self.analytics_submitted_event
       end
 
       def call
-        return if !IdentityConfig.store.doc_auth_hybrid_handoff_controller_enabled
-
         if flow_session[:skip_upload_step]
           redirect_to idv_document_capture_url
           flow_session[:flow_path] = 'standard'