Skip to content

LG-9866 remove route to 404 pg #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svalexander merged 8 commits into from
Jun 13, 2023
Merged

LG-9866 remove route to 404 pg #8499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e278a0
remove route to 404 pg
svalexander May 26, 2023
8b9a028
remove refs to maybe redirect to verify info
svalexander May 30, 2023
813fac6
lint fixes
svalexander May 30, 2023
4003c88
add back in helper as it should be removed in another pr
svalexander May 31, 2023
7cf0c51
remove line
svalexander May 31, 2023
b6ae081
lint issues
svalexander May 31, 2023
270b85c
fix spacing
svalexander May 31, 2023
6692981
new line
svalexander May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/controllers/idv/in_person/verify_info_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ class VerifyInfoController < ApplicationController
include Steps::ThreatMetrixStepHelper
include VerifyInfoConcern

before_action :renders_404_if_flag_not_set
before_action :confirm_ssn_step_complete
before_action :confirm_verify_info_step_needed

Expand Down Expand Up @@ -56,10 +55,6 @@ def prev_url
idv_in_person_step_url(step: :ssn)
end

def renders_404_if_flag_not_set
render_not_found unless IdentityConfig.store.in_person_verify_info_controller_enabled
end

def pii
@pii = flow_session[:pii_from_user]
end
Expand Down
9 changes: 0 additions & 9 deletions spec/controllers/idv/in_person/verify_info_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,6 @@
:confirm_verify_info_step_needed,
)
end

it 'renders 404 if feature flag not set' do
allow(IdentityConfig.store).to receive(:in_person_verify_info_controller_enabled).
and_return(false)

get :show

expect(response).to be_not_found
end
end

context 'when in_person_verify_info_controller_enabled' do
Expand Down