LG-9271 StepIndicatorConcern uses effective user instead of current user to ensure user during hybrid flow#8357
Closed
LG-9271 StepIndicatorConcern uses effective user instead of current user to ensure user during hybrid flow#8357
Conversation
…user If user is in the hybrid flow, effective_user will deliver the user's id when current_user is nil Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> [skip changelog]
amirbey
changed the title
Contributor
|
I think it's missing the + current_step: :verify_id,that was removed here |
| before do | ||
| allow(idv_session).to receive(:verify_info_step_complete?). | ||
| and_return(verify_info_step_complete) | ||
| allow(idv_session).to receive(:address_verification_mechanism).and_return(nil) |
Contributor
There was a problem hiding this comment.
I think we need to avoid this since idv_session can be nil and won't be able to receive the method
Contributor
|
I think this has been made obsolete by #8480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9721
🛠 Summary of changes
To ensure a user exists when seeking the ProofingComponent, the StepIndicatorConcern uses the effective_user because the current_user could be nil during the document_capture step on the hybrid flow.
Background information
https://gsa-tts.slack.com/archives/C0NGESUN5/p1683224465791789