Conversation
| name: :password_confirmation, | ||
| type: :password_confirmation, |
There was a problem hiding this comment.
I think this will need to be feature flagged in some manner since it will be backwards incompatible when running alongside a version that does not require password_confirmation.
| **tag_options | ||
| ) | ||
| @form = form | ||
| @label = label |
There was a problem hiding this comment.
Looks like the assigned value here may not exist in scope. Should it be a constructor argument?
| "version": "1.0.0", | ||
| "peerDependencies": { | ||
| "react": "^17.0.2" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "react": { | ||
| "optional": true | ||
| } | ||
| } |
There was a problem hiding this comment.
It doesn't appear that we're using React in the package.
| "version": "1.0.0", | |
| "peerDependencies": { | |
| "react": "^17.0.2" | |
| }, | |
| "peerDependenciesMeta": { | |
| "react": { | |
| "optional": true | |
| } | |
| } | |
| "version": "1.0.0" |
| /** | ||
| * Text or password confirmation input. | ||
| */ | ||
| get input_confirmation(): HTMLInputElement { |
There was a problem hiding this comment.
We should use camel-case in JavaScript (typically I'd expect the linter to flag this, but I don't know if it applies to class function names).
| get input_confirmation(): HTMLInputElement { | |
| get inputConfirmation(): HTMLInputElement { |
| return this.querySelector('.password-confirmation__input1')! as HTMLInputElement; | ||
| } | ||
|
|
||
| /** | ||
| * Text or password confirmation input. | ||
| */ | ||
| get input_confirmation(): HTMLInputElement { | ||
| return this.querySelector('.password-confirmation__input2')! as HTMLInputElement; |
There was a problem hiding this comment.
If we're calling these "input" and "input confirmation" in the code, maybe we could represent the class names similarly for consistency?
| return this.querySelector('.password-confirmation__input1')! as HTMLInputElement; | |
| } | |
| /** | |
| * Text or password confirmation input. | |
| */ | |
| get input_confirmation(): HTMLInputElement { | |
| return this.querySelector('.password-confirmation__input2')! as HTMLInputElement; | |
| return this.querySelector('.password-confirmation__input')! as HTMLInputElement; | |
| } | |
| /** | |
| * Text or password confirmation input. | |
| */ | |
| get input_confirmation(): HTMLInputElement { | |
| return this.querySelector('.password-confirmation__input-confirmation')! as HTMLInputElement; |
3 participants
No description provided.