Skip to content

Add correct phone finder help center link #8086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbighorse merged 9 commits into from
Mar 30, 2023
Merged

Add correct phone finder help center link #8086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3eb1510
Mark URL to be replaced
kbighorse Mar 28, 2023
7903922
Use correct help center article in phone form link
kbighorse Mar 28, 2023
d7fdcb1
Remove marker
kbighorse Mar 28, 2023
5fd349b
Replace references to obsolete phone number help center article
kbighorse Mar 29, 2023
96bb539
Merge branch 'main' into LG-9051-phone-finder-help-center-link
kbighorse Mar 29, 2023
59094ff
Merge branch 'main' into LG-9051-phone-finder-help-center-link
kbighorse Mar 30, 2023
047dea5
Add link to help center phone article to phone error warning screen
kbighorse Mar 30, 2023
3fdf735
Add location field to options
kbighorse Mar 30, 2023
6a4dfcb
Remove warning location option for non-warning screen
kbighorse Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/marketing_site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class MarketingSite
verify-your-identity/accepted-state-issued-identification
verify-your-identity/how-to-add-images-of-your-state-issued-id
verify-your-identity/verify-your-identity-in-person
verify-your-identity/phone-number-and-phone-plan-in-your-name
verify-your-identity/phone-number
verify-your-identity/verify-your-address-by-mail
get-started/authentication-options
].to_set.freeze
Expand Down
4 changes: 2 additions & 2 deletions app/views/idv/doc_auth/welcome.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
t('idv.troubleshooting.options.learn_more_address_verification_options'),
help_center_redirect_path(
category: 'verify-your-identity',
article: 'phone-number-and-phone-plan-in-your-name',
article: 'phone-number',
flow: :idv,
step: :welcome,
location: 'you_will_need',
Expand Down Expand Up @@ -82,7 +82,7 @@
{
url: help_center_redirect_path(
category: 'verify-your-identity',
article: 'phone-number-and-phone-plan-in-your-name',
article: 'phone-number',
flow: :idv,
step: :welcome,
location: 'missing_items',
Expand Down
2 changes: 1 addition & 1 deletion app/views/idv/phone/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
{
url: help_center_redirect_url(
category: 'verify-your-identity',
article: 'phone-number-and-phone-plan-in-your-name',
article: 'phone-number',
flow: :idv,
step: :phone,
),
Expand Down
11 changes: 11 additions & 0 deletions app/views/idv/phone_errors/_warning.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@ locals:
text: t('idv.troubleshooting.options.contact_support', app_name: APP_NAME),
new_tab: true,
},
{
url: help_center_redirect_url(
category: 'verify-your-identity',
article: 'phone-number',
flow: :idv,
step: :phone,
Comment thread
kbighorse marked this conversation as resolved.
),
text: t('idv.troubleshooting.options.learn_more_verify_by_phone'),
new_tab: true,
location: local_assigns.fetch(:name, 'warning'),
Copy link
Copy Markdown
Contributor

@aduth aduth Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed previously, but this also is in the troubleshooting option, not the URL options, so would not be tracked as expected.

Copy link
Copy Markdown
Contributor Author

@kbighorse kbighorse Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #8115

},
@gpo_letter_available && {
text: t('idv.troubleshooting.options.verify_by_mail'),
url: idv_gpo_path,
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/doc_auth/welcome_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def expect_doc_auth_upload_step
flow: 'idv',
redirect_url: MarketingSite.help_center_article_url(
category: 'verify-your-identity',
article: 'phone-number-and-phone-plan-in-your-name',
article: 'phone-number',
),
)
end
Expand All @@ -80,7 +80,7 @@ def expect_doc_auth_upload_step
flow: 'idv',
redirect_url: MarketingSite.help_center_article_url(
category: 'verify-your-identity',
article: 'phone-number-and-phone-plan-in-your-name',
article: 'phone-number',
),
)
end
Expand Down