Skip to content

Conditionally remove SendLink step from DocAuthFlow #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 2 commits into from
Mar 21, 2023
Merged

Conditionally remove SendLink step from DocAuthFlow #8033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88ac46
Temporary! Conditionally remove SendLink step from DocAuthFlow
soniaconnolly Mar 20, 2023
4cff611
Fix UploadStep step spec
soniaconnolly Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/services/idv/flows/doc_auth_flow.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ class DocAuthFlow < Flow::BaseFlow
welcome: Idv::Steps::WelcomeStep,
agreement: Idv::Steps::AgreementStep,
upload: Idv::Steps::UploadStep,
send_link: Idv::Steps::SendLinkStep,
**(IdentityConfig.store.doc_auth_combined_hybrid_handoff_enabled ?
{} : { send_link: Idv::Steps::SendLinkStep }),
Comment on lines +8 to +9
Copy link
Contributor

@zachmargolis zachmargolis Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wanted to flag that adding conditional definitions of constants can be tricky for testing, because the tests could be created with the wrong value. From the description, it sounded like this is temporary, so I'm not too worried

Copy link
Contributor Author

@soniaconnolly soniaconnolly Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. In this case I know at least some of the specs were working because I had the values in the wrong order to start with and it made a test fail.

link_sent: Idv::Steps::LinkSentStep,
email_sent: Idv::Steps::EmailSentStep,
document_capture: Idv::Steps::DocumentCaptureStep,
Expand Down
3 changes: 2 additions & 1 deletion spec/services/idv/steps/upload_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
ActionController::Parameters.new(
{
doc_auth: { phone: '(201) 555-1212' },
combined: true,
},
)
end
Expand Down Expand Up @@ -61,7 +62,7 @@
end

subject(:step) do
Idv::Steps::SendLinkStep.new(flow)
Idv::Steps::UploadStep.new(flow)
end

before do
Expand Down