Conditionally remove SendLink step from DocAuthFlow#8033
Merged
soniaconnolly merged 2 commits intomainfrom Mar 21, 2023
Merged
Conversation
When the doc_auth_combined_hybrid_handoff_enabled feature flag is enabled, the SendLink step is not used. Conditionally remove it from the DocAuthFlow so that the send_link url is not accessed in the 50/50 state when the feature flag and SendLink code are fully removed. Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov> [skip changelog]
kbighorse
approved these changes
Mar 20, 2023
theabrad
approved these changes
Mar 20, 2023
Comment on lines
+8
to
+9
| **(IdentityConfig.store.doc_auth_combined_hybrid_handoff_enabled ? | ||
| {} : { send_link: Idv::Steps::SendLinkStep }), |
Contributor
There was a problem hiding this comment.
just wanted to flag that adding conditional definitions of constants can be tricky for testing, because the tests could be created with the wrong value. From the description, it sounded like this is temporary, so I'm not too worried
Contributor
Author
There was a problem hiding this comment.
Good point. In this case I know at least some of the specs were working because I had the values in the wrong order to start with and it made a test fail.
UploadStep spec was testing SendLinkStep instead. Update to test the right step. Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
jmhooper
approved these changes
Mar 21, 2023
jmhooper
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Temporary! Conditionally remove SendLink step from DocAuthFlow When the doc_auth_combined_hybrid_handoff_enabled feature flag is enabled, the SendLink step is not used. Conditionally remove it from the DocAuthFlow so that the send_link url is not accessed in the 50/50 state when the feature flag and SendLink code are fully removed. [skip changelog] * Fix UploadStep step spec UploadStep spec was testing SendLinkStep instead. Update to test the right step. Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8903
🛠 Summary of changes
When the doc_auth_combined_hybrid_handoff_enabled feature flag is enabled, the SendLink step is not used. Conditionally remove it from the DocAuthFlow so that the send_link url is not accessed in the 50/50 state when the feature flag and SendLink code are fully removed.
This is an attempt to avoid the 500 errors we saw when we deployed #7929 last week. This code is a temporary bridge and will be removed when we re-deploy the big cleanup PR.
Co-authored-by: Kimball Bighorse kimball.bighorse@gsa.gov
[skip changelog]