LG-9067: Account reset account deleted event fixes#7982
Merged
olatifflexion merged 4 commits intomainfrom Mar 15, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
olatif/LG-9067-acct-reset-bug
branch
from
bba817f to
16f3ea2
Compare
Contributor
There was a problem hiding this comment.
typically we call this column service_provider or issuer, I have a slight preference for issuer and maybe if we wanted to be clear, we could call it requesting_issuer or something
Contributor
Author
There was a problem hiding this comment.
I like requesting_issuer, I added sp_issuer because it was in the ticket but I will change this to requesting_issuer.
olatifflexion
force-pushed
the
olatif/LG-9067-acct-reset-bug
branch
2 times, most recently
from
2154608 to
bba817f
Compare
changelog: Internal, Attempts API, Update & fixes Account reset account deleted event
mitchellhenke
force-pushed
the
olatif/LG-9067-acct-reset-bug
branch
from
d3808ed to
1d88e98
Compare
zachmargolis
approved these changes
Mar 14, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, some small comments but this is good to go!
| sp: sp, | ||
| cookie_device_uuid: cookies[:device], | ||
| sp_request_uri: nil, | ||
| enabled_for_session: sp.irs_attempts_api_enabled?, |
Contributor
There was a problem hiding this comment.
@n1zyy this just reminder me of this line in your PR:
We have the enabled_for_session so the tracker will no-op if it's not enabled, we can do that instead of having a. nillable tracker
Merged
svalexander
pushed a commit
that referenced
this pull request
Mar 16, 2023
* LG-9067: Account reset account deleted event fixes changelog: Internal, Attempts API, Update & fixes Account reset account deleted event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts API, Update & fixes Account reset account deleted event