-
Notifications
You must be signed in to change notification settings - Fork 166
LG-8664 | Log Attempt Event for fraud account ops #7951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
31f8336
squashing everything down
jmhooper a40288f
Add analytics; work around silly rubocop gripe
n1zyy 221109c
Now with valid syntax!
n1zyy 57d15bc
Indicate whether this is an automatic or manual rejection
n1zyy aa5912d
Remove extraneous comment
n1zyy b7f5d6c
Merge branch 'main' into mattw/LG-8664_profile_reviewed
n1zyy 58dc792
Trivial rubocop fix
n1zyy d475f1f
Merge branch 'main' into mattw/LG-8664_profile_reviewed
n1zyy 6fc3511
Merge branch 'main' into mattw/LG-8664_profile_reviewed
n1zyy 379362a
Adds FraudEvent and supporting classes
n1zyy 86ca981
Some cleanup
n1zyy b2ef936
Merge branch 'main' into mattw/LG-8664_profile_reviewed
n1zyy 9abe73c
User has_one, not _many, fraud_event(s)
n1zyy 73e54d9
Clean up yard docs, remove unnecessary nil-safe operator
n1zyy 718b76b
lint fixes
n1zyy 9c6adcc
PR feedback
n1zyy 7a528d2
Adds feature flag; cleans up along the way
n1zyy deac2e3
Removes useless variable assignment
n1zyy 10f9ad7
Merge branch 'main' into mattw/LG-8664_profile_reviewed
n1zyy e3861f6
Apply suggestions from code review
n1zyy 92adfd9
Fix rubocop + tests
n1zyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| class FraudReviewRequest < ApplicationRecord | ||
| include NonNullUuid | ||
|
|
||
| belongs_to :user | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
db/primary_migrate/20230322000756_create_fraud_review_requests.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| class CreateFraudReviewRequests < ActiveRecord::Migration[7.0] | ||
| def change | ||
| create_table :fraud_review_requests do |t| | ||
| t.integer :user_id | ||
| t.string :uuid | ||
| t.string :irs_session_id | ||
| t.string :login_session_id | ||
|
|
||
| t.timestamps | ||
|
|
||
| t.index :user_id, unique: false | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happened across this while looking at how
NonNullUuidwas used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops good catch