Skip to content

LG-8930: Show formatted date of birth on in-person proofing verify step #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomas-nava merged 3 commits into from
Mar 14, 2023
Merged

LG-8930: Show formatted date of birth on in-person proofing verify step #7975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa075fc
show formatted date of birth on IPP verify step
Mar 10, 2023
6fb3a1d
comment to clarify date formats
Mar 14, 2023
02dd78a
Merge remote-tracking branch 'origin/main' into tomas/lg-8930-full-mo…
Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/views/idv/shared/_verify.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ locals:
</div>
<div>
<dt class="display-inline"> <%= t('idv.form.dob') %>: </dt>
<dd class="display-inline margin-left-0"> <%= pii[:dob] %> </dd>
<dd class="display-inline margin-left-0">
<%= I18n.l(Date.parse(pii[:dob]), format: I18n.t('time.formats.event_date')) %>
</dd>
</div>
<% if !remote_identity_proofing %>
<div>
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/in_person_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
expect(page).to have_content(t('headings.verify'))
expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_LAST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_DOB)
expect(page).to have_text(InPersonHelper::GOOD_DOB_FORMATTED_EVENT)
expect(page).to have_text(InPersonHelper::GOOD_STATE_ID_NUMBER)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_text(InPersonHelper::GOOD_CITY)
Expand Down Expand Up @@ -152,7 +152,7 @@
expect(page).to have_content(t('headings.verify'))
expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_LAST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_DOB)
expect(page).to have_text(InPersonHelper::GOOD_DOB_FORMATTED_EVENT)
expect(page).to have_text(InPersonHelper::GOOD_STATE_ID_NUMBER)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_text(InPersonHelper::GOOD_CITY)
Expand Down
6 changes: 1 addition & 5 deletions spec/features/idv/steps/in_person/verify_info_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@
expect(page).to have_content(t('headings.verify'))
expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_LAST_NAME)
i18n_dob = I18n.l(
Date.parse(InPersonHelper::GOOD_DOB),
format: I18n.t('time.formats.event_date'),
)
expect(page).to have_text(i18n_dob)
expect(page).to have_text(InPersonHelper::GOOD_DOB_FORMATTED_EVENT)
expect(page).to have_text(InPersonHelper::GOOD_STATE_ID_NUMBER)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_text(InPersonHelper::GOOD_CITY)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/idv/steps/in_person/verify_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
expect(page).to have_content(t('headings.verify'))
expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_LAST_NAME)
expect(page).to have_text(InPersonHelper::GOOD_DOB)
expect(page).to have_text(InPersonHelper::GOOD_DOB_FORMATTED_EVENT)
Copy link

@carmenrosalop carmenrosalop Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good in the three languages

expect(page).to have_text(InPersonHelper::GOOD_STATE_ID_NUMBER)
expect(page).to have_text(InPersonHelper::GOOD_ADDRESS1)
expect(page).to have_text(InPersonHelper::GOOD_CITY)
Expand Down
5 changes: 5 additions & 0 deletions spec/support/features/in_person_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ module InPersonHelper

GOOD_FIRST_NAME = Idp::Constants::MOCK_IDV_APPLICANT[:first_name]
GOOD_LAST_NAME = Idp::Constants::MOCK_IDV_APPLICANT[:last_name]
# the date in the format '1938-10-06'
GOOD_DOB = Idp::Constants::MOCK_IDV_APPLICANT[:dob]
# the date in the format 'October 6, 1938'
GOOD_DOB_FORMATTED_EVENT = I18n.l(
Date.parse(GOOD_DOB), format: I18n.t('time.formats.event_date')
)
GOOD_STATE_ID_JURISDICTION = Idp::Constants::MOCK_IDV_APPLICANT_FULL_STATE_ID_JURISDICTION
GOOD_STATE_ID_NUMBER = Idp::Constants::MOCK_IDV_APPLICANT[:state_id_number]

Expand Down