LG-8930: Show formatted date of birth on in-person proofing verify step#7975
Merged
tomas-nava merged 3 commits intomainfrom Mar 14, 2023
Merged
LG-8930: Show formatted date of birth on in-person proofing verify step#7975tomas-nava merged 3 commits intomainfrom
tomas-nava merged 3 commits intomainfrom
Conversation
soniaconnolly
approved these changes
Mar 10, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! One naming suggestion.
svalexander
reviewed
Mar 13, 2023
svalexander
approved these changes
Mar 14, 2023
added 2 commits
March 14, 2023 12:55
changelog: User-Facing Improvements, Verify your information for in person proofing, Show formatted date of birth
mitchellhenke
force-pushed
the
tomas/lg-8930-full-month-for-dob
branch
from
7e8b182 to
6fb3a1d
Compare
|
Looks good! Thanks Tomas |
| expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME) | ||
| expect(page).to have_text(InPersonHelper::GOOD_LAST_NAME) | ||
| expect(page).to have_text(InPersonHelper::GOOD_DOB) | ||
| expect(page).to have_text(InPersonHelper::GOOD_DOB_FORMATTED_EVENT) |
There was a problem hiding this comment.
The changes look good in the three languages
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8930
🛠 Summary of changes
On the Verify your information screen, show the Date of Birth in full month format.
📜 Testing Plan
👀 Screenshots
before (en):
after (en, es, fr):