Merged
Conversation
* Comment hybrid handoff analytics events * [skip changelog]
* add analytics events for link clicks * add analytics events for links on ready to verify pg * update show.htm.erb_spec * wip tests * add click events to integration test * lint fixes * changelog: Internal, Analytics Events, add analytics event for usps e… * changelog: Internal, Analytics Events, add analytics events for links on ready to veryify page * remove unused code and comment
* Moved reset_email call to fix probable race condition We were clearing the email queue after the call to send the email. This _usually_ worked because of UI delays in sending the mail. * Added email_spec/rspec as an experiment Seems like it should've been there; let's see what blows up. (It adds a before(:each) to reset the email queue) [skip changelog]
We are retiring the FSM and the verify step is the first step to be removed. Previous put work in place to retired gracefully. Once this code is no longer running in prod this PR should be safe to merge. The `VerifyWait` and `VerifyWaitStepShow` were removed as they are associated with the Verify step and are not needed without it. [skip changelog] per PR feedback from @zachmargolis Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
jmhooper
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal