Skip to content

LG-8712 log links on ready to verify#7796

Merged
svalexander merged 10 commits intomainfrom
shannon/lg-8712-log-links-on-ready-to-verify
Feb 13, 2023
Merged

LG-8712 log links on ready to verify#7796
svalexander merged 10 commits intomainfrom
shannon/lg-8712-log-links-on-ready-to-verify

Conversation

@svalexander
Copy link
Contributor

@svalexander svalexander commented Feb 8, 2023

🎫 Ticket

Lg-8712

🛠 Summary of changes

This pr adds analytics events for when a user clicks the following 2 links on the ready to verify page:

  • service provider link
  • what to bring link

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Run identity-oidc-sinatra application in addition to this application
  • Open rails console: rails c
  • Update service provider: ServiceProvider.where(friendly_name: 'Example Sinatra App').update(return_to_sp_url: "http://localhost:9292")
  • Exit: exit
  • Open: http://localhost:9292
  • Go through ipp flow using a failed id
  • Click sp link
  • Verify event is in events.log
  • Click what to bring link
  • Verify event is in events.log

Screen Shot 2023-02-10 at 1 57 01 PM

@svalexander svalexander marked this pull request as draft February 8, 2023 16:30
@svalexander svalexander marked this pull request as ready for review February 10, 2023 18:46
@svalexander svalexander requested review from a team and NavaTim February 10, 2023 18:46
@svalexander svalexander merged commit 15ce840 into main Feb 13, 2023
@svalexander svalexander deleted the shannon/lg-8712-log-links-on-ready-to-verify branch February 13, 2023 15:56
@svalexander svalexander changed the title Shannon/lg 8712 log links on ready to verify LG-8712 log links on ready to verify Feb 13, 2023
@mitchellhenke mitchellhenke mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants