Deploy RC 252 to Production#7815
Merged
mitchellhenke merged 7 commits intostages/prodfrom Feb 13, 2023
Merged
Conversation
…" page (#7781) Add personal_key_generated_at to User model Display personal key generation date on "reactivate your account" page
Resolves LG-6146 changelog: Internal, Deployment, Add support for environment-specific content in configuration
* LG-8771: Implement reCAPTCHA on phone setup screens [skip changelog] * Render captcha submit button as submit button No-JS compatibility for feature disabled/exempt cases * Assign exempt countries only when captcha enabled By not assigning countries, it falls back to the "always exempt" behavior, which is how it should work when feature is disabled * Rename exempt to isExempt Practice what you preach: Inform as boolean * Render hidden input from CaptchaSubmitButtonComponent 1. Allows a means to show the error message 2. Avoids awkwardness of server-side param permitting 3. Simplifies JavaScript * Move constants top of file * Handle Faraday errors for reCAPTCHA validation * Add logging for reCAPTCHA result * Move constants top of file * Add score threshold to analytics * Add service name to Faraday instrumentation * Remove default button content for submit button Needs to be customizable (e.g. "Send one time code") * Reference submit button by form query * Consider absence of reCAPTCHA key as exemption Avoids needing exemption to be considered as external consideration of PhoneInputComponent * Add README for captcha-submit-button package * Revert SpinnerButton default action message, default in captcha button I remember now that it was intentional to avoid the default action message as a way to force the implementer to acknowledge and include a relevant message to be announced to assistive technology. "Verifying..." is pretty widespread, but not really a great choice describing the inherent behavior of a spinner button * Render captcha submit button as submit button Default for spinnerbutton is plain button (probably shouldn't be =/) * Separate configuration check from exemption "exempt" and "doesn't have requisite config" should be considered as separate things * Remove unused spinnerButton instance function * Add specs for CaptchaSubmitButtonElement * Avoid rendering reCAPTCHA script when reCAPTCHA disabled * Add specs for CaptchaSubmitButtonComponent * Normalize YAML * Stop spinner spinning on invalid form * Update PhoneSetupController specs * Short-circuit invalid result for missing reCAPTCHA token * Remove reCAPTCHA error expectations Default configuration would have reCAPTCHA disabled, so there ought not be any errors * Add specs for RecaptchaValidator * Add specs for PhoneSetupRecaptchaValidator * Update specs for PhoneInputComponent * Override CSP for reCAPTCHA only when enabled * Add specs for RecaptchaConcern * Update NewPhoneForm specs for recaptcha handling * Use UriService for adding URL parameters Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Use delegating for PhoneSetupRecaptchaValidator See #7761 (comment) * Remove NewRelic error notice for unsuccessful validation See: #7761 (comment) We are already logging a detail to CloudWatch we can track * Handle captcha challenge exemption as event cancellation See: #7761 (comment) * Render SpinnerButton explicitly, not as subclass * Remove class_name from reCAPTCHA validator analytics We're no longer subclassing, so this wasn't providing an accurate detail. Could consider in the future if we need to disambiguate, at which point maybe we add a "context" property to the class constructor. * Rename PhoneSetupRecaptcha to PhoneRecaptcha More abbreviated, could allow reuse, shouldn't be restricted to setup * Use consistent naming convention for custom events lg:component:action * Include evaluated result in analytics payload * Log class name for reCAPTCHA connection exception * Add coverage for nil analytics * Avoid logging for exempt, blank reCAPTCHA --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…error page (#7798) * changelog: User-facing improvements, In-person proofing, Change default IPP CTA text to nationwide variant. * Reverting so fallback text is available, removing unnecessary prop
* LG-8188 Fix double failure reason on idv otp event changelog: Internal, Attempts API, Standardize events
* Reduce session size with encoding and compression changes changelog: Internal, Performance, Reduce session size * remove metric logging * add msgpack to Gemfile * Update lib/legacy_session_encryptor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * rename Small -> V2 * rename Legacy back to regular * add specs * add "deprecation" warnings * add frozen_string_literal * constantize session payload keys --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove PWA manifest file changelog: Internal, Performance, Remove progressive web app manifest to avoid extra network request * Remove unused favicon
aduth
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal