LG-8783 Update IPP CTA with nationwide language on barcode attention error page#7798
Conversation
…lt IPP CTA text to nationwide variant.
| {altHeading || t('in_person_proofing.headings.cta')} | ||
| </h2> | ||
| <p>{altPrompt || t('in_person_proofing.body.cta.prompt_detail')}</p> | ||
| <p>{altPrompt}</p> |
There was a problem hiding this comment.
Currently altPrompt is set as optional for this component. If a value isn't provided, we won't show any content here. This departs from the existing pattern of fallback values for altHeading, altPrompt and altButtonText.
Rather than making altPrompt required and removing the fallback to the (now updated) in_person_proofing.body.cta.prompt_detail, could we instead leave this file as-is and remove unnecessary props in the components calling this one?
| heading={t('components.troubleshooting_options.ipp_heading')} | ||
| altInPersonCta={t('in_person_proofing.headings.cta_variant')} | ||
| altInPersonPrompt={t('in_person_proofing.body.cta.prompt_detail_a')} | ||
| altInPersonPrompt={t('in_person_proofing.body.cta.prompt_detail')} |
There was a problem hiding this comment.
We can omit this line entirely if we leave the fallback in in-person-call-to-action.tsx.
There was a problem hiding this comment.
Tying this comment into your previous statement "could we instead leave this file as-is and remove unnecessary props in the components calling this one?"
This is the only place where the input prop matches the fallback text, so this is the only prop that can be removed FYI.
3 participants
🎫 Ticket? TICKET.
🛠 Summary of changes
With the advent of the nationwide launch, the default state of the IPP CTA has changed. The previous language referring to D.C. and Baltimore only P.O. locations is irrelevant. So this is a minor change to make the default language that of CTA version A.
📜 Testing Plan
Since the changes to the frontend have already been made, there shouldn't be any changes to the text displayed.
👀
Screenshots