Skip to content

Enhance automated accessibility tests to check idref validity#7642

Merged
aduth merged 6 commits intomainfrom
aduth-valid-aria-describedby
Jan 17, 2023
Merged

Enhance automated accessibility tests to check idref validity#7642
aduth merged 6 commits intomainfrom
aduth-valid-aria-describedby

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jan 13, 2023 •
edited
Loading

🛠 Summary of changes

Updates accessibility feature specs to check for valid ID references for aria-describedby and aria-labelledby.

Related:

📜 Testing Plan

  1. Intentionally introduce errors to page HTML (e.g. git cherry-pick 84ce1c5)
  2. rspec ./spec/features/accessibility/visitor_pages_spec.rb:5
  3. Observe failures

Example:

  1) Accessibility on pages that do not require authentication login / root path
     Failure/Error: expect(page).to have_valid_idrefs
     
       Found 1 elements with invalid ID reference links:
     
       [aria-describedby="not-exists"]

aduth added 3 commits January 13, 2023 11:00
@aduth
Enhance automated accessibility tests to check idref validity
650ce2f 
changelog: Internal, Automated Testing, Enhance accessibility tests to check for invalid HTML markup
@aduth
Example bad markup
84ce1c5
@aduth
Revert "Example bad markup"
341e4aa 
This reverts commit 84ce1c5.
@aduth aduth requested a review from nickttng January 13, 2023 16:04
nickttng
nickttng approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

zachmargolis
zachmargolis approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis zachmargolis mentioned this pull request Jan 13, 2023
Merged
@aduth aduth merged commit 7b87b35 into main Jan 17, 2023
@aduth aduth deleted the aduth-valid-aria-describedby branch January 17, 2023 18:21
@mdiarra3 mdiarra3 mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickttng nickttng nickttng approved these changes

@mdiarra3 mdiarra3 mdiarra3 approved these changes

+1 more reviewer

@zachmargolis zachmargolis zachmargolis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accessibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduth @zachmargolis @nickttng @mdiarra3