Enhance automated accessibility tests to check markup validity#7640
Merged
Enhance automated accessibility tests to check markup validity#7640
Conversation
nickttng
approved these changes
Jan 13, 2023
Contributor
nickttng
left a comment
There was a problem hiding this comment.
Thank you for looking into this! 👍🏼
changelog: Internal, Automated Testing, Enhance accessibility tests to check for invalid HTML markup
See: #7640 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
see inline code comments
09aadad to
d96b3e3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates accessibility feature specs to check for valid HTML markup.
Related Slack discussion: https://gsa-tts.slack.com/archives/C01C89LM6UF/p1673541645409329
The implementation ended up being more difficult than I expected, due to how the existing specs run using ChromeDriver, and Chrome will try to automatically repair much of the invalid HTML we're interested in.
📜 Testing Plan
git cherry-pick 226bee4)rspec ./spec/features/accessibilityExample: