Remove Proofing::Result class

app/services/proofing/aamva/proofer.rb

@@ -29,12 +29,12 @@ def initialize(config)
       def proof(applicant)
         aamva_applicant =
           Aamva::Applicant.from_proofer_applicant(OpenStruct.new(applicant))
-        verification_response = Aamva::VerificationClient.new(
+        response = Aamva::VerificationClient.new(
           config,
         ).send_verification_request(
           applicant: aamva_applicant,
         )
-        build_result_from_response(verification_response)
+        build_result_from_response(response)
       rescue => exception
         NewRelic::Agent.notice_error(exception)
         Proofing::StateIdResult.new(

app/services/proofing/address_result.rb

@@ -1,7 +1,12 @@
 module Proofing
   class AddressResult
-    attr :success, :errors, :exception, :vendor_name, :transaction_id, :reference,
-         :vendor_workflow
+    attr_reader :success,
+                :errors,
+                :exception,
+                :vendor_name,
+                :transaction_id,
+                :reference,
+                :vendor_workflow
 
     def initialize(
       success:,

app/services/proofing/result.rb → app/services/proofing/ddp_result.rb

@@ -1,7 +1,11 @@
 module Proofing
-  class Result
+  class DdpResult
     attr_reader :exception
-    attr_accessor :context, :transaction_id, :reference, :review_status, :response_body
+    attr_accessor :context,
+                  :transaction_id,
+                  :reference,
+                  :review_status,
+                  :response_body
 
     def initialize(
         errors: {},
@@ -26,10 +30,6 @@ def add_error(key = :base, error)
     end
     # rubocop:enable Style/OptionalArguments
 
-    def attributes_requiring_additional_verification
-      []
-    end
-
     def errors
       @errors.transform_values(&:to_a)
     end
@@ -46,10 +46,6 @@ def failed?
       !exception? && errors?
     end
 
-    def failed_result_can_pass_with_additional_verification?
-      false
-    end
-
     def success?
       !exception? && !errors?
     end

app/services/proofing/lexis_nexis/config.rb

@@ -0,0 +1,24 @@
+module Proofing
+  module LexisNexis
+    Config = RedactedStruct.new(
+      :instant_verify_workflow,
+      :phone_finder_workflow,
+      :account_id,
+      :base_url,
+      :username,
+      :password,
+      :request_mode,
+      :request_timeout,
+      :org_id,
+      :api_key,
+      keyword_init: true,
+      allowed_members: [
+        :instant_verify_workflow,
+        :phone_finder_workflow,
+        :base_url,
+        :request_mode,
+        :request_timeout,
+      ],
+    )
+  end
+end

app/services/proofing/lexis_nexis/ddp/proofer.rb

@@ -30,57 +30,35 @@ def stage
           end
         end
 
-        Config = RedactedStruct.new(
-          :instant_verify_workflow,
-          :phone_finder_workflow,
-          :account_id,
-          :base_url,
-          :username,
-          :password,
-          :request_mode,
-          :request_timeout,
-          :org_id,
-          :api_key,
-          keyword_init: true,
-          allowed_members: [
-            :instant_verify_workflow,
-            :phone_finder_workflow,
-            :base_url,
-            :request_mode,
-            :request_timeout,
-          ],
-        )
-
         attr_reader :config
 
         def initialize(attrs)
           @config = Config.new(attrs)
         end
 
-        def send_verification_request(applicant)
-          VerificationRequest.new(config: config, applicant: applicant).send
-        end
-
         def proof(applicant)
-          response = send_verification_request(applicant)
-          process_response(response)
+          response = VerificationRequest.new(config: config, applicant: applicant).send
+          build_result_from_response(response)
         rescue => exception
           NewRelic::Agent.notice_error(exception)
-          Proofing::Result.new(exception: exception)
+          Proofing::DdpResult.new(exception: exception)
         end
 
         private
 
-        def process_response(response)
-          result = Proofing::Result.new
-          body = response.response_body
+        def build_result_from_response(verification_response)
+          result = Proofing::DdpResult.new
+          body = verification_response.response_body
+
           result.response_body = body
           result.transaction_id = body['request_id']
           request_result = body['request_result']
           review_status = body['review_status']
+
           result.review_status = review_status
           result.add_error(:request_result, request_result) unless request_result == 'success'
           result.add_error(:review_status, review_status) unless review_status == 'pass'
+
           result
         end
       end

app/services/proofing/lexis_nexis/instant_verify/proofer.rb

@@ -5,7 +5,7 @@ class Proofer
         attr_reader :config
 
         def initialize(config)
-          @config = LexisNexis::Ddp::Proofer::Config.new(config)
+          @config = LexisNexis::Config.new(config)
         end
 
         def proof(applicant)

app/services/proofing/lexis_nexis/phone_finder/proofer.rb

@@ -5,12 +5,12 @@ class Proofer
         attr_reader :config
 
         def initialize(config)
-          @config = LexisNexis::Ddp::Proofer::Config.new(config)
+          @config = LexisNexis::Config.new(config)
         end
 
         def proof(applicant)
           response = VerificationRequest.new(config: config, applicant: applicant).send
-          return build_result_from_response(response)
+          build_result_from_response(response)
         rescue => exception
           NewRelic::Agent.notice_error(exception)
           AddressResult.new(

app/services/proofing/mock/ddp_mock_client.rb

@@ -32,7 +32,7 @@ def stage
       TRANSACTION_ID = 'ddp-mock-transaction-id-123'
 
       def proof(applicant)
-        result = Proofing::Result.new
+        result = Proofing::DdpResult.new
         result.transaction_id = TRANSACTION_ID
 
         response_body = File.read(

app/services/proofing/resolution_result.rb

@@ -1,15 +1,22 @@
 module Proofing
   class ResolutionResult
-    attr_reader :success, :errors, :exception, :vendor_name, :transaction_id, :verified_attributes,
+    attr_reader :errors,
+                :exception,
+                :success,
+                :vendor_name,
+                :transaction_id,
+                :verified_attributes,
                 :failed_result_can_pass_with_additional_verification,
                 :attributes_requiring_additional_verification,
-                :reference, :vendor_workflow, :drivers_license_check_info
+                :reference,
+                :vendor_workflow,
+                :drivers_license_check_info
 
     def initialize(
-      success:,
-      errors:,
-      exception:,
-      vendor_name:,
+      success: nil,
+      errors: {},
+      exception: nil,
+      vendor_name: nil,
       transaction_id: '',
       reference: '',
       failed_result_can_pass_with_additional_verification: false,
@@ -39,10 +46,6 @@ def timed_out?
       exception.is_a?(Proofing::TimeoutError)
     end
 
-    def failed_result_can_pass_with_additional_verification?
-      failed_result_can_pass_with_additional_verification
-    end
-
     def to_h
       {
         success: success?,
@@ -58,5 +61,9 @@ def to_h
         drivers_license_check_info: drivers_license_check_info,
       }
     end
+
+    def failed_result_can_pass_with_additional_verification?
+      failed_result_can_pass_with_additional_verification
+    end
   end
 end

app/services/proofing/state_id_result.rb

@@ -1,12 +1,17 @@
 module Proofing
   class StateIdResult
-    attr_reader :success, :errors, :exception, :vendor_name, :transaction_id, :verified_attributes
+    attr_reader :errors,
+                :exception,
+                :success,
+                :vendor_name,
+                :transaction_id,
+                :verified_attributes
 
     def initialize(
-      success:,
-      errors:,
-      exception:,
-      vendor_name:,
+      success: nil,
+      errors: {},
+      exception: nil,
+      vendor_name: nil,
       transaction_id: '',
       verified_attributes: []
     )

spec/jobs/resolution_proofing_job_spec.rb

@@ -320,9 +320,9 @@
       context 'with a successful response from the proofer' do
         before do
           expect(resolution_proofer).to receive(:proof).
-            and_return(Proofing::Result.new)
+            and_return(Proofing::ResolutionResult.new)
           expect(state_id_proofer).to receive(:proof).
-            and_return(Proofing::Result.new)
+            and_return(Proofing::StateIdResult.new)
           Proofing::Mock::DeviceProfilingBackend.new.record_profiling_result(
             session_id: threatmetrix_session_id,
             result: 'pass',
@@ -355,7 +355,7 @@
         end
 
         context 'nil response body from ddp' do
-          let(:ddp_result) { Proofing::Result.new(response_body: nil) }
+          let(:ddp_result) { Proofing::DdpResult.new(response_body: nil) }
 
           before do
             expect(ddp_proofer).to receive(:proof).and_return(ddp_result)
@@ -381,9 +381,9 @@
       context 'does call state id with an unsuccessful response from the proofer' do
         it 'posts back to the callback url' do
           expect(resolution_proofer).to receive(:proof).
-            and_return(Proofing::Result.new(exception: 'error'))
+            and_return(Proofing::ResolutionResult.new(exception: 'error'))
           expect(state_id_proofer).to receive(:proof).
-            and_return(Proofing::Result.new)
+            and_return(Proofing::StateIdResult.new)
 
           perform
         end
@@ -394,7 +394,7 @@
 
         it 'does not call state_id proof if resolution proof is successful' do
           expect(resolution_proofer).to receive(:proof).
-            and_return(Proofing::Result.new)
+            and_return(Proofing::ResolutionResult.new)
 
           expect(state_id_proofer).not_to receive(:proof)
           perform

spec/services/idv/steps/verify_wait_step_show_spec.rb

@@ -1,13 +1,15 @@
 require 'rails_helper'
 
 describe Idv::Steps::VerifyWaitStepShow do
+  TRANSACTION_ID = 'ddp-mock-transaction-id-123'
+
   include Rails.application.routes.url_helpers
 
   let(:user) { build(:user) }
   let(:issuer) { 'test_issuer' }
   let(:service_provider) { build(:service_provider, issuer: issuer) }
-  let(:resolution_transaction_id) { Proofing::Mock::ResolutionMockClient::TRANSACTION_ID }
-  let(:threatmetrix_transaction_id) { Proofing::Mock::DdpMockClient::TRANSACTION_ID }
+  let(:resolution_transaction_id) { TRANSACTION_ID }
+  let(:threatmetrix_transaction_id) { TRANSACTION_ID }
 
   let(:request) { FakeRequest.new }
 

spec/services/proofing/aamva/proofing_spec.rb

@@ -5,13 +5,15 @@
   let(:aamva_applicant) do
     Aamva::Applicant.from_proofer_applicant(OpenStruct.new(state_id_data))
   end
+
   let(:state_id_data) do
     {
       state_id_number: '1234567890',
       state_id_jurisdiction: 'VA',
       state_id_type: 'drivers_license',
     }
   end
+
   let(:verification_results) do
     {
       state_id_number: true,
@@ -25,7 +27,9 @@
     }
   end
 
-  subject { described_class.new(AamvaFixtures.example_config.to_h) }
+  subject do
+    described_class.new(AamvaFixtures.example_config.to_h)
+  end
 
   let(:verification_response) { AamvaFixtures.verification_response }