Skip to content

Remove ial2 columns #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbighorse merged 13 commits into from
Jan 19, 2023
Merged

Remove ial2 columns #7615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b7f39dc
Remove ial2 columns
kbighorse Jan 11, 2023
4f9d350
[skip changelog]
kbighorse Jan 11, 2023
378051e
Remove acuant_selfie from token allow list in add sp cost
kbighorse Jan 11, 2023
37b9aac
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 11, 2023
26718d9
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 11, 2023
2290c82
Restore `pgcrypto` extension in schema
kbighorse Jan 11, 2023
035764f
Use single quotes
kbighorse Jan 11, 2023
3ab59df
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 13, 2023
f3dfbd0
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 13, 2023
97a9a88
Stop ignoring deleted columns
kbighorse Jan 13, 2023
962b48a
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 17, 2023
03667de
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 18, 2023
1ed8b61
Merge branch 'main' into LG-8012-remove-ial2-strict-db-columns
kbighorse Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/models/doc_auth_log.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@ class DocAuthLog < ApplicationRecord
foreign_key: 'issuer',
primary_key: 'issuer'
# rubocop:enable Rails/InverseOf

self.ignored_columns = ['selfie_view_at']
end
2 changes: 0 additions & 2 deletions app/models/document_capture_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ class DocumentCaptureSession < ApplicationRecord

belongs_to :user

self.ignored_columns = ['ial2_strict']

def load_result
EncryptedRedisStructStorage.load(result_id, type: DocumentCaptureSessionResult)
end
Expand Down
1 change: 0 additions & 1 deletion app/services/db/sp_cost/add_sp_cost.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class SpCostTypeError < StandardError; end
acuant_front_image
acuant_back_image
acuant_result
acuant_selfie
lexis_nexis_resolution
lexis_nexis_address
gpo_letter
Expand Down
6 changes: 6 additions & 0 deletions db/primary_migrate/20230111013539_delete_ial2_columns.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class DeleteIal2Columns < ActiveRecord::Migration[7.0]
def change
safety_assured { remove_column :document_capture_sessions, :ial2_strict }
safety_assured { remove_column :doc_auth_logs, :selfie_view_at }
end
end
Comment on lines +1 to +6
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to do this in a separate PR from adding ignored_columns because during a deploy old boxes will still try to load columns that have been dropped

Copy link
Copy Markdown
Contributor Author

@kbighorse kbighorse Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Copy Markdown
Contributor Author

@kbighorse kbighorse Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #7622

Copy link
Copy Markdown
Contributor Author

@kbighorse kbighorse Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merg'd #7622

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh also this PR can be updated to remove the .ignored_columns line because those columns don't exist anymore

2 changes: 0 additions & 2 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@
t.integer "enter_info_view_count", default: 0
t.datetime "success_view_at", precision: nil
t.integer "success_view_count", default: 0
t.datetime "selfie_view_at", precision: nil
t.integer "selfie_view_count", default: 0
t.integer "selfie_submit_count", default: 0
t.integer "selfie_error_count", default: 0
Expand Down Expand Up @@ -188,7 +187,6 @@
t.datetime "created_at", precision: nil, null: false
t.datetime "updated_at", precision: nil, null: false
t.datetime "requested_at", precision: nil
t.boolean "ial2_strict"
t.string "issuer"
t.datetime "cancelled_at", precision: nil
t.boolean "ocr_confirmation_pending", default: false
Expand Down