Merged
Conversation
Comment on lines
+1
to
+6
| class DeleteIal2Columns < ActiveRecord::Migration[7.0] | ||
| def change | ||
| safety_assured { remove_column :document_capture_sessions, :ial2_strict } | ||
| safety_assured { remove_column :doc_auth_logs, :selfie_view_at } | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
I think we need to do this in a separate PR from adding ignored_columns because during a deploy old boxes will still try to load columns that have been dropped
Contributor
There was a problem hiding this comment.
oh also this PR can be updated to remove the .ignored_columns line because those columns don't exist anymore
aduth
reviewed
Jan 11, 2023
zachmargolis
approved these changes
Jan 13, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! but we need to wait to merge this until #7622 is deployed
Contributor
Author
|
👌🏾 can do, still a bit remaining on this one in the meantime |
Contributor
Author
|
CI failed on |
Contributor
Author
|
re-ran, CI now passing 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
🛠 Summary of changes
Blocked by this PR which marks columns to be ignored first