Skip to content

Raise exception when session store cannot connect to Redis #7583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 4 commits into from
Jan 5, 2023
Merged

Raise exception when session store cannot connect to Redis #7583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7f127d
Raise exception when session cannot connect to Redis
Jan 5, 2023
cee7a4f
add failing spec
Jan 5, 2023
6ec799a
Update config/initializers/session_store.rb
Jan 5, 2023
bb8d8ab
remove unnecessary file
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/initializers/session_store.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
client: REDIS_SESSION_POOL_WRAPPER,
},
on_session_load_error: SessionEncryptorErrorHandler,
on_redis_down: proc { |error, _env, _sid| raise error },
serializer: SessionEncryptor.new,
)
12 changes: 12 additions & 0 deletions spec/requests/redis_down_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
require 'rails_helper'

RSpec.describe 'redis down session error handling' do
context 'with bad Redis connection' do
it 'fails loudly' do
allow(REDIS_SESSION_POOL_WRAPPER).to receive(:setex).and_raise(Redis::CannotConnectError)
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

expect do
get forgot_password_path
end.to raise_error(Redis::CannotConnectError)
end
end
end