Raise exception when session store cannot connect to Redis#7583
Merged
mitchellhenke merged 4 commits intomainfrom Jan 5, 2023
Merged
Raise exception when session store cannot connect to Redis#7583mitchellhenke merged 4 commits intomainfrom
mitchellhenke merged 4 commits intomainfrom
Conversation
added 2 commits
January 5, 2023 12:26
changelog: Internal, Session Handling, Raise exception when session cannot connect to Redis
zachmargolis
reviewed
Jan 5, 2023
| RSpec.describe 'redis down session error handling' do | ||
| context 'with bad Redis connection' do | ||
| it 'fails loudly' do | ||
| allow(REDIS_SESSION_POOL_WRAPPER).to receive(:setex).and_raise(Redis::CannotConnectError) |
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
reviewed
Jan 5, 2023
mitchellhenke
force-pushed
the
mitchellhenke/fail-loudly-on-session-redis-down
branch
from
551ab3c to
bb8d8ab
Compare
mitchellhenke
deleted the
mitchellhenke/fail-loudly-on-session-redis-down
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Kind of a sibling PR to #7547. This adds a handler to the Redis session store configuration to re-raise Redis connection errors. This change is intended to ensure that it is apparent to us and end users when a critical piece of the system is down.