Add option to include_identity_session_attributes in IdentityLinker#7421
Closed
zachmargolis wants to merge 5 commits intomargolis-identity-linker-cleanupfrom
Closed
Add option to include_identity_session_attributes in IdentityLinker#7421zachmargolis wants to merge 5 commits intomargolis-identity-linker-cleanupfrom
zachmargolis wants to merge 5 commits intomargolis-identity-linker-cleanupfrom
Conversation
And also basic test / factory update changelog: Internal, Attempts API, ServiceProviderIdentity has consented scope
This introduces linter error on too-long comments that won't stay, so ignore them for now.
zachmargolis
commented
Dec 2, 2022
| @ial = ial | ||
| now = Time.zone.now | ||
| process_ial_at(now) | ||
| process_ial_at(now) if include_identity_session_attributes |
Contributor
Author
There was a problem hiding this comment.
in hindsight, it's frustrating that these ial_at columns were added to this table, and updated in this way because they make this all kind of complicated
n1zyy
reviewed
Dec 2, 2022
| expect(identity.access_token).to be_nil | ||
| expect(identity.last_ial1_authenticated_at).to be_nil | ||
| expect(identity.last_ial2_authenticated_at).to be_nil | ||
| expect(identity.verified_at).to be_nil |
Contributor
There was a problem hiding this comment.
Just because my brain has been so focused on last_consented_at—this whole change is unrelated to that, and is looking ahead to the next step, right?
Contributor
Author
There was a problem hiding this comment.
yeah I just wanted to make sure that the row was as blank as possible
zachmargolis
force-pushed
the
margolis-identity-linker-cleanup
branch
from
bb179dd to
2a0064d
Compare
Contributor
Author
|
Closing this out since we've chosen not to do #7418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7420 which is a follow-up to #7418
Adds a new option to IdentityLinker which I expect we could use when we create Agency UUIDs ahead of consent.