Merged
Conversation
[skip changelog]
zachmargolis
approved these changes
Nov 29, 2022
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, good catch, thanks!
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I think #7314 introduced some mutation of the constant that can affect other tests and may not always clean it up which can lead to failed specs elsewhere (example)
To reproduce the flaky test reliably, run
rspec spec/lib/telephony/pinpoint/sms_sender_spec.rb spec/lib/telephony/telephony_spec.rb --seed 8116, which should result in:This PR tries to ensure that all of the client pool mocking is reset in this spec file.