Skip to content

Remove files from knapsack report that no longer exist#7373

Merged
zachmargolis merged 1 commit intomainfrom
margolis-knapsack-cleanup
Nov 21, 2022
Merged

Remove files from knapsack report that no longer exist#7373
zachmargolis merged 1 commit intomainfrom
margolis-knapsack-cleanup

Conversation

@zachmargolis
Copy link
Contributor

As part of #7372, I noticed that there are a bunch of files in the knapsack report that no longer exist in the repo, so I just ran this little script.

I feel like in an ideal world, we'd have some sort of artifact that generate from CI and automatically update it, do some sort of moving average calculation so that CI balances itself out better. But in the meantime, this!

Another option is writing a linter that makes sure that the report doesn't contain files that don't exist?

> ruby knapsack_cleanup.rb < knapsack_rspec_report.json | pbcopy
> pbpate > knapsack_rspec_report.json
> cat knapsack_cleanup.rb 
require 'json'

report = JSON.parse(STDIN.read)

filtered = report.select { |path, _time| File.exist?(path) }

puts JSON.pretty_generate(filtered)

Base automatically changed from margolis-drop-partner-api to main November 18, 2022 21:41
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're probably overdue to regenerate this whole file, but this is good cleanup / incremental step in the meantime 👍

@zachmargolis zachmargolis force-pushed the margolis-knapsack-cleanup branch from 00ee5db to 1741af5 Compare November 18, 2022 21:43
@zachmargolis zachmargolis merged commit 101eafd into main Nov 21, 2022
@zachmargolis zachmargolis deleted the margolis-knapsack-cleanup branch November 21, 2022 16:49
mdiarra3 added a commit that referenced this pull request Nov 21, 2022
* Remove unreachable blank config lockout default logic (#7357)

* Remove unreachable blank config lockout default logic

changelog: Internal, Code Quality, Remove unreachable code paths

* Replace references for removed constant

* Use Rails ActiveSupport for "time ago"

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* LG-8056 Encrypt document submissions and write them to S3 (#7351)

This commit adds tooling for encrypting documents and writing them to S3 after upload.

This is an addition to the attempts API. Eventually a reference for the image and an encryption key will be shared with IRS via the attmepts API. IRS will be able to use that reference and key to request the images associated with a document upload event. The changes to add those values to the attempts API are out of scope for this change and will follow in another commit.

The images are encrypted first with AES-256 using a randomnly generated key. The images are then uploaded to an S3 bucket with KMS encryption enabled. This offers protection that matches our current approach to PII storage, but with a partner controlled key instead of the user's password.

This implementation is partner specific. Since the images are only available to service providers that are using the attempts API it should only be enabled when the attempts API is also enabled.

[skip changelog]

* LG-8139: Increase max OTP confirmation attempts (#7358)

* LG-8139: Increase max OTP confirmation attempts

changelog: Improvements, Multi-factor Authentication, Increase number of allowed MFA confirmation attempts before lock-out

* Replace hard-coded max OTP attempts in specs

* Fix specs, split by max attempts bucket

* LG-8046: stop webauthn platform for new registrations/accounts (#7338)

* changelog: Improvements, Authentication, Disable new registering of platform auth accounts

* default webauthn off for now

* disable webauthn

* change naming convention for feature toggle

* change naming convention

* update webauthn platform

* add feature spec for sign in

* add test to ensure users dont see unneeded adding of platform auth in their account page

* fix html

* update spec and yml file

* remove unneeded spec

* dont show if u dont have face/touch unlock

* update to split up webauthn platform and romaing

* switch roaming and platform

* Drop ial2_quota tables (#7339)

[skip changelog]

* Shannon/lg 7522 update contact strings (#7362)

* update strings and links

* update failed fraud to include correct strings and links

* changelog: Improvements, Results emails, update text

* update reset pw link

* Drop proofing_costs table (LG-8028) (#7346)


[skip changelog]

* Try to fix flakey email spec (#7359)

changelog: Internal, Automated Testing, Improve reliability of successful automated tests

* Fix flakey IPP sample data rake spec (#7363)

* Fix flakey IPP sample data rake spec

changelog: Internal, Automated Testing, Improve reliability of successful automated tests

* Call / stub Kernel.sleep

See: #7363 (comment)

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Add configurable phone carrier registration blocklist (#7366)

changelog: Improvements, Phone Registration, Add configurable phone carrier registration blocklist

* Remove unused PartnerApiReport(#7372)

- Remove associated API code, basically a revert of #5054

changelog: Internal, Reporting, Remove unused reporting code

* Prepare build-sass package for publish (#7370)

* Prepare build-sass package for publish

[skip changelog]

* Re-add private field

Required by linter

* Add README.md

* Add more package.json metadata

* Add LICENSE.md

* Remove files from knapsack report that no longer exist (#7373)

[skip changelog]

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Shannon A <20867088+svalexander@users.noreply.github.com>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants