Skip to content

Add initial Partner API with agencies and partner accounts#5054

Merged
orenyk merged 1 commit intomainfrom
oyk-partner-api-agencies-accounts
May 20, 2021
Merged

Add initial Partner API with agencies and partner accounts#5054
orenyk merged 1 commit intomainfrom
oyk-partner-api-agencies-accounts

Conversation

@orenyk
Copy link
Contributor

@orenyk orenyk commented May 12, 2021

Resolves #LG-4236

  • Add Agreements::Reports::BaseReport to upload Partner API JSON files
    to the correct S3 buckets
  • Add the Blueprinter gem for JSON serialization and add serializers for
    agencies and partner accounts
  • Add some helper methods to the PartnerAccountStatus model and some
    missing associations
  • Add job to run the PartnerApiReport regularly

@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch 2 times, most recently from 6803523 to 18eaeae Compare May 13, 2021 02:44
@orenyk orenyk changed the base branch from main to oyk-partner-api-v1 May 13, 2021 02:46
@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch from 18eaeae to 25f3e02 Compare May 13, 2021 03:44
@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch from 25f3e02 to 8677631 Compare May 14, 2021 04:35
@jmhooper
Copy link
Contributor

A reminder to change the base on this one to main

@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch 2 times, most recently from b0e13c9 to d6b5742 Compare May 19, 2021 19:58
@orenyk orenyk requested a review from jmhooper May 19, 2021 19:58
@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch from d6b5742 to 2733353 Compare May 19, 2021 20:00
@orenyk orenyk changed the base branch from oyk-partner-api-v1 to main May 19, 2021 20:01
@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch 2 times, most recently from cb2b732 to 5a08617 Compare May 19, 2021 22:39
Resolves #LG-4236

* Add Agreements::Reports::BaseReport to upload Partner API JSON files
  to the correct S3 buckets
* Add the Blueprinter gem for JSON serialization and add serializers for
  agencies and partner accounts
* Add some helper methods to the PartnerAccountStatus model and some
  missing associations
* Add job to run the PartnerApiReport regularly
@orenyk orenyk force-pushed the oyk-partner-api-agencies-accounts branch from 5a08617 to 4cccf9f Compare May 20, 2021 02:21
@orenyk orenyk merged commit b0efc7f into main May 20, 2021
@orenyk orenyk deleted the oyk-partner-api-agencies-accounts branch May 20, 2021 02:38
zachmargolis added a commit that referenced this pull request Nov 18, 2022
- Remove associated API code, basically a revert of #5054

changelog: Internal, Reporting, Remove unused reporting code
zachmargolis added a commit that referenced this pull request Nov 18, 2022
- Remove associated API code, basically a revert of #5054

changelog: Internal, Reporting, Remove unused reporting code
mdiarra3 added a commit that referenced this pull request Nov 21, 2022
* Remove unreachable blank config lockout default logic (#7357)

* Remove unreachable blank config lockout default logic

changelog: Internal, Code Quality, Remove unreachable code paths

* Replace references for removed constant

* Use Rails ActiveSupport for "time ago"

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* LG-8056 Encrypt document submissions and write them to S3 (#7351)

This commit adds tooling for encrypting documents and writing them to S3 after upload.

This is an addition to the attempts API. Eventually a reference for the image and an encryption key will be shared with IRS via the attmepts API. IRS will be able to use that reference and key to request the images associated with a document upload event. The changes to add those values to the attempts API are out of scope for this change and will follow in another commit.

The images are encrypted first with AES-256 using a randomnly generated key. The images are then uploaded to an S3 bucket with KMS encryption enabled. This offers protection that matches our current approach to PII storage, but with a partner controlled key instead of the user's password.

This implementation is partner specific. Since the images are only available to service providers that are using the attempts API it should only be enabled when the attempts API is also enabled.

[skip changelog]

* LG-8139: Increase max OTP confirmation attempts (#7358)

* LG-8139: Increase max OTP confirmation attempts

changelog: Improvements, Multi-factor Authentication, Increase number of allowed MFA confirmation attempts before lock-out

* Replace hard-coded max OTP attempts in specs

* Fix specs, split by max attempts bucket

* LG-8046: stop webauthn platform for new registrations/accounts (#7338)

* changelog: Improvements, Authentication, Disable new registering of platform auth accounts

* default webauthn off for now

* disable webauthn

* change naming convention for feature toggle

* change naming convention

* update webauthn platform

* add feature spec for sign in

* add test to ensure users dont see unneeded adding of platform auth in their account page

* fix html

* update spec and yml file

* remove unneeded spec

* dont show if u dont have face/touch unlock

* update to split up webauthn platform and romaing

* switch roaming and platform

* Drop ial2_quota tables (#7339)

[skip changelog]

* Shannon/lg 7522 update contact strings (#7362)

* update strings and links

* update failed fraud to include correct strings and links

* changelog: Improvements, Results emails, update text

* update reset pw link

* Drop proofing_costs table (LG-8028) (#7346)


[skip changelog]

* Try to fix flakey email spec (#7359)

changelog: Internal, Automated Testing, Improve reliability of successful automated tests

* Fix flakey IPP sample data rake spec (#7363)

* Fix flakey IPP sample data rake spec

changelog: Internal, Automated Testing, Improve reliability of successful automated tests

* Call / stub Kernel.sleep

See: #7363 (comment)

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

* Add configurable phone carrier registration blocklist (#7366)

changelog: Improvements, Phone Registration, Add configurable phone carrier registration blocklist

* Remove unused PartnerApiReport(#7372)

- Remove associated API code, basically a revert of #5054

changelog: Internal, Reporting, Remove unused reporting code

* Prepare build-sass package for publish (#7370)

* Prepare build-sass package for publish

[skip changelog]

* Re-add private field

Required by linter

* Add README.md

* Add more package.json metadata

* Add LICENSE.md

* Remove files from knapsack report that no longer exist (#7373)

[skip changelog]

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Shannon A <20867088+svalexander@users.noreply.github.com>
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants