LG-7185: Add error handling and analytics to in-person proofing email reminder job#7364
Merged
tomas-nava merged 11 commits intoshannon/lg-7185-email-reminders-job-newfrom Nov 21, 2022
Conversation
tomas-nava
changed the title
added 2 commits
November 21, 2022 11:48
[skip changelog]
tomas-nava
deleted the
tomas/lg-7185-add-error-handling-and-analytics
branch
svalexander
added a commit
that referenced
this pull request
Nov 29, 2022
* email job * moving email job file and fixing missing end * send partially working * email job working * include test for needs email reminder * add test for excluded enrollments * make methods private * fall back to app name if sp_name is not available * changelog:Improvement, Job, add email reminder job * db migration * update email reminder so it covers a range of dates * can be equal to end interval * adjust interval * update config names * make input param names clearer and change time to make sure correct dates included * update email reminder tests * lint fix * update calculation so excludes enrollments on late benchmark and includes ones on early benchmark * fix test so correct enrollments are picked based on established_at time * fix lint issue * check flags are false and remove unneeded test * move email reminder job to in person folder * fix lint * job spec * continued work on job spec * check enrollment code * update to email job * some tests pass and others fail * tests working and lint changes * update naming * refactor based on feedback * update tests * remove unneeded nil check * LG-7185: Add error handling and analytics to in-person proofing email reminder job (#7364) * add new analytics events * add analytics and error handling to job * add analytics expectations to tests * add test for error handling (currently failing) * job refactor * remove put statement * error is raised but occurs 2x * execption logged test passes * separate error test for clarity * fix lint by documenting parameter * fix spelling Co-authored-by: Shannon Alexander <shannon.alexander-navarro@gsa.gov> * pluralize email subject and header by days left we might send the email when there's only one day left Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7185
🛠 Summary of changes
Add basic error handling and analytics for
InPerson::EmailReminderJob