LG-7185: Send email reminders for in-person proofing enrollments#7256
Merged
svalexander merged 40 commits intomainfrom Nov 29, 2022
Merged
LG-7185: Send email reminders for in-person proofing enrollments#7256svalexander merged 40 commits intomainfrom
svalexander merged 40 commits intomainfrom
Conversation
aduth
reviewed
Nov 1, 2022
…udes ones on early benchmark
svalexander
commented
Nov 7, 2022
svalexander
commented
Nov 7, 2022
svalexander
commented
Nov 7, 2022
| email_address: email_address, | ||
| ).in_person_ready_to_verify_reminder( | ||
| enrollment: enrollment, | ||
| ).deliver_now |
Contributor
Author
There was a problem hiding this comment.
would there be any issues if there were a large number of emails being sent using deliver_now - 500+? Anything to consider here?
Contributor
There was a problem hiding this comment.
deliver_now would mean that we'd email synchronously in the job, so that would increase how long this job takes to run, worst case, it would take too long and collide with the next run of the job?
tomas-nava
reviewed
Nov 14, 2022
...te/20221031203041_add_early_reminder_sent_and_late_reminder_sent_to_in_person_enrollments.rb
Outdated
Show resolved
Hide resolved
tomas-nava
reviewed
Nov 14, 2022
tomas-nava
reviewed
Nov 15, 2022
… reminder job (#7364) * add new analytics events * add analytics and error handling to job * add analytics expectations to tests * add test for error handling (currently failing) * job refactor * remove put statement * error is raised but occurs 2x * execption logged test passes * separate error test for clarity * fix lint by documenting parameter * fix spelling Co-authored-by: Shannon Alexander <shannon.alexander-navarro@gsa.gov>
…-reminders-job-new
…-reminders-job-new
we might send the email when there's only one day left
| @@ -0,0 +1,95 @@ | |||
| # frozen_string_literal: true | |||
Contributor
There was a problem hiding this comment.
looks good! starting a thread here arbitrarily for small design comments @tomas-nava
- Can we shift which text we are linking in the bottom of the box outlining items to bring from "Questions about what to bring? Learn more" to "Questions? Learn more about what to bring." (indicating what text should be linked here with bold). Also linking this design that accurately reflects what I mean. I also believe our link style uses an underline, if we could add that here.
- Are we able to add more space between the sentence "You can see any associate at the retail window to verify your identity" and "Your deadline to verify your identity in person is..." at the bottom of the email to more accurately reflect the design above as well?
…-reminders-job-new
tomas-nava
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-7185
🛠 Summary of changes
This pr is to add the job for the email reminder. This job is to run daily. The job checks enrollments that fit the database query in needs_email_reminders - these are enrollments that have a pending status, have an established_at date and have at least 11 days left till their enrollment period ends.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Open the rails console
e = InPersonEnrollment.laste.update(status: "pending")InPerson::EmailReminderJob.new.perform(Time.zone.now)👀 Screenshots
en- 10 days:
en- 3 days:
en- 1 day:
es- 10 days:
es- 3 days:
es- 1 day:
fr- 10 days:
fr- 3 days:
fr- 1 day: