Skip to content

LG-8068: Increase # of times voice message repeats when sending MFA codes #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdembe merged 8 commits into from
Nov 21, 2022
Merged

LG-8068: Increase # of times voice message repeats when sending MFA codes #7356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91ab16d
Fix confirmation OTP text
jmdembe Nov 17, 2022
d7234b6
fix test
jmdembe Nov 17, 2022
5023880
Merge branch 'main' into LG-8068-repeat-voice-message
jmdembe Nov 17, 2022
31a197c
normalize english yaml
jmdembe Nov 17, 2022
1a6994a
Add final english language text
jmdembe Nov 18, 2022
4d1a517
clea up en yml file
jmdembe Nov 18, 2022
360dfbe
fix test (again)
jmdembe Nov 18, 2022
f09cdaf
add translated text
jmdembe Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions config/locales/telephony/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ en:
%{app_name}: Your one-time code is %{code}. It expires in %{expiration} minutes. Don't share this code with anyone.

@%{domain} #%{code}
voice: Hello! Your %{app_name} one time passcode is, %{code}, again, your
passcode is, %{code}, This code expires in %{expiration} minutes.
voice: Hello! Your %{app_name} one-time code is, %{code}. Your one-time code is,
%{code}. Again, your one-time code is %{code}. This code expires in
%{expiration} minutes.
confirmation_otp:
sms: |-
%{app_name}: Your one-time code is %{code}. It expires in %{expiration} minutes. Don't share this code with anyone.

@%{domain} #%{code}
voice: Hello! Your %{app_name} one time passcode is, %{code}, again, your
passcode is, %{code}, This code expires in %{expiration} minutes.
voice: Hello! Your %{app_name} one-time code is, %{code}. Your one-time code is,
%{code}. Again, your one-time code is %{code}. This code expires in
%{expiration} minutes.
doc_auth_link: "%{link} You've requested to verify your identity on a mobile
phone. Please take a photo of your state issued ID."
error:
Expand Down
12 changes: 6 additions & 6 deletions config/locales/telephony/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ es:
%{app_name}: El código de un solo uso es %{code}. Este código se vence en %{expiration} minutos. No lo comparta con ninguna persona.

@%{domain} #%{code}
voice: '¡Hola! Su código de acceso de %{app_name} es, %{code}, nuevamente, su
código de acceso es %{code}, Este código caducará en %{expiration}
minutos.'
voice: ¡Hola! Su código único de %{app_name} es %{code}, Su código único es
%{code}, De nuevo, su código único es %{code}, Este código expira en
%{expiration} minutos".
confirmation_otp:
sms: |-
%{app_name}: El código de un solo uso es %{code}. Este código se vence en %{expiration} minutos. No lo comparta con ninguna persona.

@%{domain} #%{code}
voice: '¡Hola! Su código de acceso de %{app_name} es, %{code}, nuevamente, su
código de acceso es %{code}, Este código caducará en %{expiration}
minutos.'
voice: ¡Hola! Su código único de %{app_name} es %{code}, Su código único es
%{code}, De nuevo, su código único es %{code}, Este código expira en
%{expiration} minutos".
doc_auth_link: '%{link} Has solicitado verificar tu identidad en un teléfono
móvil. Por favor, tome una foto de la identificación emitida por su
estado'
Expand Down
12 changes: 6 additions & 6 deletions config/locales/telephony/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ fr:
%{app_name}: Votre code à usage unique est %{code}. Il est valable pendant %{expiration} minutes. Vous ne devez pas partager ce code avec personne.

@%{domain} #%{code}
voice: Bonjour! Votre code de sécurité à utilisation unique de %{app_name} est,
%{code}, de nouveau, votre code de sécurité est, %{code}, Ce code
expirera dans %{expiration} minutes.
voice: Bonjour! Votre code %{app_name} à usage unique est %{code}, Votre code à
usage unique est %{code}, Une fois de plus, votre code à usage unique
est %{code}, Ce code expire dans %{expiration} minutes.
confirmation_otp:
sms: |-
%{app_name}: Votre code à usage unique est %{code}. Il est valable pendant %{expiration} minutes. Vous ne devez pas partager ce code avec personne.

@%{domain} #%{code}
voice: Bonjour! Votre code de sécurité à utilisation unique de %{app_name} est,
%{code}, de nouveau, votre code de sécurité est, %{code}, Ce code
expirera dans %{expiration} minutes.
voice: Bonjour! Votre code %{app_name} à usage unique est %{code}. Votre code à
usage unique est %{code}. Une fois de plus, votre code à usage unique
est %{code}. Ce code expire dans %{expiration} minutes.
doc_auth_link: "%{link} Vous avez demandé à vérifier votre identité sur un
téléphone mobile. S'il vous plaît prendre une photo de votre identité
émise par l'état"
Expand Down
25 changes: 6 additions & 19 deletions spec/lib/telephony/otp_sender_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,20 +137,14 @@
message = <<~XML.squish
<speak>
<prosody rate='slow'>
Hello! Your #{APP_NAME} one time passcode is,
Hello! Your #{APP_NAME} one-time code is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6,
again, your passcode is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6,
This code expires in 5 minutes.
</prosody>
</speak>
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6.
XML

adapter = instance_double(Telephony::Pinpoint::VoiceSender)
expect(adapter).to receive(:send).with(
message: message,
message: start_with(message),
to: to,
otp: otp,
country_code: country_code,
Expand All @@ -164,26 +158,19 @@
message = <<~XML.squish
<speak>
<prosody rate='slow'>
Hello! Your #{APP_NAME} one time passcode is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6,
again, your passcode is,
Hello! Your #{APP_NAME} one-time code is,
1 <break time='0.5s' /> 2 <break time='0.5s' /> 3 <break time='0.5s' />
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6,
This code expires in 5 minutes.
</prosody>
</speak>
4 <break time='0.5s' /> 5 <break time='0.5s' /> 6.
XML

adapter = instance_double(Telephony::Pinpoint::VoiceSender)
expect(adapter).to receive(:send).with(
message: message,
message: start_with(message),
to: to,
otp: otp,
country_code: country_code,
)
expect(Telephony::Pinpoint::VoiceSender).to receive(:new).and_return(adapter)

subject.send_confirmation_otp
end

Expand Down