Skip to content

LG-8068: Increase # of times voice message repeats when sending MFA codes#7356

Merged
jmdembe merged 8 commits intomainfrom
LG-8068-repeat-voice-message
Nov 21, 2022
Merged

LG-8068: Increase # of times voice message repeats when sending MFA codes#7356
jmdembe merged 8 commits intomainfrom
LG-8068-repeat-voice-message

Conversation

@jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Nov 17, 2022

🎫 Ticket

LG-8068: Increase # of times voice message repeats when sending MFA codes

🛠 Summary of changes

This ticket makes voice OTP calls to repeat three times instead of twice

📜 Testing Plan

Technical

  • Make sure test pass

Manual

  • Create an account on this sandbox.
  • Set up Text or Voice message as authentication method
  • Enter phone number
  • See results

@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from 73f2505 to e7bb670 Compare November 17, 2022 16:07
@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from e7bb670 to 91ab16d Compare November 17, 2022 17:47
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from 04374be to d7234b6 Compare November 17, 2022 20:45
changelog: Improvements, accessibility, announce voice OTP three times
@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from 78d740d to 31a197c Compare November 17, 2022 21:12
@jmdembe jmdembe marked this pull request as ready for review November 18, 2022 14:21
@jmdembe jmdembe requested a review from a team November 18, 2022 14:21
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a technical point-of-view, but I had one clarifying comment about expected content.

Comment on lines +13 to +15
voice: Hello! Your %{app_name} one time passcode is, %{code}. Your one time
passcode is, %{code}. Again, your passcode is, %{code}. This code
expires in %{expiration} minutes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if this is the final content? I had seen some discussion on Slack about changing "passcode" to "code" for consistency. I expect we'd also need translations for these changes.

Copy link
Contributor Author

@jmdembe jmdembe Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final content will be "Hello! Your Login.gov one-time code is, 123456. Your one-time code is, 123456. Again, your one-time code is 123456. This code expires in 10 minutes."

I can change this reference here, and throughout the codebase (thankfully, there aren't many references "one-time passcode" to the forward-facing user.) I will also check in with UX team so that they can be on the same page.

@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from e0a4a33 to e54e910 Compare November 18, 2022 15:41
@jmdembe jmdembe force-pushed the LG-8068-repeat-voice-message branch from e54e910 to 1a6994a Compare November 18, 2022 15:42
@jmdembe jmdembe changed the title LG-8068: First pass: repeat voice OTP 3 times LG-8068: Increase # of times voice message repeats when sending MFA codes Nov 21, 2022
@jmdembe jmdembe merged commit fb453aa into main Nov 21, 2022
@jmdembe jmdembe deleted the LG-8068-repeat-voice-message branch November 21, 2022 21:33
@mdiarra3 mdiarra3 mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants