Skip to content

Updated .usa-alert--info-important style to bold text. #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmax-gsa merged 1 commit into from
Nov 1, 2022
Merged

Updated .usa-alert--info-important style to bold text. #7258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/stylesheets/components/_alert.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.usa-alert--info-important {
@include u-bg('accent-cool-darker');
color: color('white');
font-weight: 500;
Copy link
Contributor

@aduth aduth Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we only define 400 and 700 font weights, and due to how fallback weight behavior would choose the normal font weight, I wouldn't expect this change to have any effect, and in my testing it appears visually the same as if this line didn't exist at all.

If we wanted bold, I would expect...

Suggested change
font-weight: 500;
font-weight: bold;


&::before {
background-image: url('alert/info-white.svg');
Expand Down