Skip to content

Jskinne3 lg 7653 intermittent tests 2 #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jskinne3 merged 11 commits into from
Oct 18, 2022
Merged

Jskinne3 lg 7653 intermittent tests 2 #7159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ba4793
Restore README change from abandoned prior branch
jskinne3 Oct 12, 2022
981f77c
Add increased file descriptor .plist to README
jskinne3 Oct 14, 2022
090aa85
Move error item into error section of README
jskinne3 Oct 14, 2022
f819c5a
Include sassc-rails gem to resolve intermitten test errors
jskinne3 Oct 17, 2022
fa84108
Remove sassc-rails per Michelle Henke's advice it's no longer used
jskinne3 Oct 17, 2022
7e06b4b
Remove sassc-rails from Gemfile.lock
jskinne3 Oct 17, 2022
c6826ee
changelog: Added, README, increase file descriptor limit
jskinne3 Oct 18, 2022
c121304
changelog: Added, README, increase file descriptor limit
jskinne3 Oct 18, 2022
77474ce
[skip changelog]
jskinne3 Oct 18, 2022
a7ee9ce
Include nano command to edit .plist file in README
jskinne3 Oct 18, 2022
44fb4cf
remove capybara-selenium
theabrad Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ end
group :test do
gem 'axe-core-rspec', '~> 4.2'
gem 'bundler-audit', require: false
gem 'capybara-selenium', '>= 0.0.6'
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just because we no longer use selenium, right?

Copy link
Copy Markdown
Contributor

@theabrad theabrad Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the webdrivers gem contains all of the different webdrivers, and capybara-selenium hasn't been updated since 2014. This gem was just there to make capybara work with selenium, but that is handled with webdrivers now.

Copy link
Copy Markdown
Contributor Author

@jskinne3 jskinne3 Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! ✨ really glad to get that outdated gem outta there

gem 'simplecov', '~> 0.21.0', require: false
gem 'simplecov-cobertura'
gem 'simplecov_json_formatter'
Expand Down
4 changes: 0 additions & 4 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,6 @@ GEM
rack-test (>= 0.6.3)
regexp_parser (>= 1.5, < 3.0)
xpath (~> 3.2)
capybara-selenium (0.0.6)
capybara
selenium-webdriver
cbor (0.5.9.6)
childprocess (4.1.0)
choice (0.2.0)
Expand Down Expand Up @@ -742,7 +739,6 @@ DEPENDENCIES
browser
bullet (~> 7.0)
bundler-audit
capybara-selenium (>= 0.0.6)
capybara-webmock!
connection_pool
cssbundling-rails
Expand Down
53 changes: 46 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,6 @@ $ bundle install
$ yarn install
```

#### I am receiving errors related to Capybara in feature tests
You may need to install _chromedriver_ or your chromedriver may be the wrong version (`$ which chromedriver && chromedriver --version`).

chromedriver can be installed using [Homebrew](https://formulae.brew.sh/cask/chromedriver) or [direct download](https://chromedriver.chromium.org/downloads). The version of chromedriver should correspond to the version of Chrome you have installed `(Chrome > About Google Chrome)`; if installing via Homebrew, make sure the versions match up.

#### I am receiving errors when creating the development and test databases

If you receive the following error (where _whoami_ == _your username_):
Expand All @@ -222,16 +217,60 @@ $ createdb `whoami`
$ make test_serial
```

##### Errors related to too many _open files_
##### Errors related to Capybara in feature tests
You may need to install _chromedriver_ or your chromedriver may be the wrong version (`$ which chromedriver && chromedriver --version`).

chromedriver can be installed using [Homebrew](https://formulae.brew.sh/cask/chromedriver) or [direct download](https://chromedriver.chromium.org/downloads). The version of chromedriver should correspond to the version of Chrome you have installed `(Chrome > About Google Chrome)`; if installing via Homebrew, make sure the versions match up. After your system recieves an automatic Chrome browser update you may have to upgrade (or reinstall) chromedriver.

If `chromedriver -v` does not work you may have to [allow it](https://stackoverflow.com/questions/60362018/macos-catalinav-10-15-3-error-chromedriver-cannot-be-opened-because-the-de) with `xattr`.

##### Errors related to _too many open files_
You may receive connection errors similar to the following:

`Failed to open TCP connection to 127.0.0.1:9515 (Too many open files - socket(2) for "127.0.0.1" port 9515)`

Running the following, _prior_ to running tests, may solve the problem:
You are encountering you OS's [limits on allowed file descriptors](https://wilsonmar.github.io/maximum-limits/). Check the limits with both:
* `ulimit -n`
* `launchctl limit maxfiles`

Try this to increase the user limit:
```
$ ulimit -Sn 65536 && make test
```
To set this _permanently_, add the following to your `~/.zshrc` or `~/.bash_profile` file, depending on your shell:
```
ulimit -Sn 65536
```

If you are running MacOS, you may find it is not taking your revised ulimit seriously. [You must insist.](https://medium.com/mindful-technology/too-many-open-files-limit-ulimit-on-mac-os-x-add0f1bfddde) Run this command to edit a property list file:
```
sudo nano /Library/LaunchDaemons/limit.maxfiles.plist
```
Paste the following contents into the text editor:
```
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN"
"http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>Label</key>
<string>limit.maxfiles</string>
<key>ProgramArguments</key>
<array>
<string>launchctl</string>
<string>limit</string>
<string>maxfiles</string>
<string>524288</string>
<string>524288</string>
</array>
<key>RunAtLoad</key>
<true/>
<key>ServiceIPC</key>
<false/>
</dict>
</plist>

```
Use Control+X to save the file.

Restart your Mac to cause the .plist to take effect. Check the limits again and you should see both `ulimit -n` and `launchctl limit maxfiles` return a limit of 524288.